From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Dave Young <dyoung@redhat.com>
Cc: "Matt Fleming" <matt@codeblueprint.co.uk>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Peter Jones" <pjones@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Mark Rutland" <mark.rutland@arm.com>,
"Josh Boyer" <jwboyer@fedoraproject.org>,
"Josh Triplett" <josh@joshtriplett.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Môshe van der Sterre" <me@moshe.nl>
Subject: [PATCH 11/11] x86/efi-bgrt: Use efi_mem_reserve() to avoid copying image data
Date: Thu, 23 Jun 2016 12:34:50 +0100 [thread overview]
Message-ID: <1466681690-5850-12-git-send-email-matt@codeblueprint.co.uk> (raw)
In-Reply-To: <1466681690-5850-1-git-send-email-matt@codeblueprint.co.uk>
efi_mem_reserve() allows us to permanently mark EFI boot services
regions as reserved, which means we no longer need to copy the image
data out and into a separate buffer.
Leaving the data in the original boot services region has the added
benefit that BGRT images can now be passed across kexec reboot.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Peter Jones <pjones@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Môshe van der Sterre <me@moshe.nl>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
---
arch/x86/platform/efi/efi-bgrt.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/arch/x86/platform/efi/efi-bgrt.c b/arch/x86/platform/efi/efi-bgrt.c
index 6a2f5691b1ab..6aad870e8962 100644
--- a/arch/x86/platform/efi/efi-bgrt.c
+++ b/arch/x86/platform/efi/efi-bgrt.c
@@ -82,21 +82,12 @@ void __init efi_bgrt_init(void)
}
bgrt_image_size = bmp_header.size;
- bgrt_image = kmalloc(bgrt_image_size, GFP_KERNEL | __GFP_NOWARN);
+ bgrt_image = memremap(bgrt_tab->image_address, bmp_header.size, MEMREMAP_WB);
if (!bgrt_image) {
- pr_notice("Ignoring BGRT: failed to allocate memory for image (wanted %zu bytes)\n",
- bgrt_image_size);
- return;
- }
-
- image = memremap(bgrt_tab->image_address, bmp_header.size, MEMREMAP_WB);
- if (!image) {
pr_notice("Ignoring BGRT: failed to map image memory\n");
- kfree(bgrt_image);
bgrt_image = NULL;
return;
}
- memcpy(bgrt_image, image, bgrt_image_size);
- memunmap(image);
+ efi_mem_reserve(bgrt_tab->image_address, bgrt_image_size);
}
--
2.7.3
next prev parent reply other threads:[~2016-06-23 11:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 11:34 [PATCH 00/11] efi: Permanent runtime EFI memmap support Matt Fleming
2016-06-23 11:34 ` [PATCH 01/11] x86/efi: Test for EFI_MEMMAP functionality when iterating EFI memmap Matt Fleming
2016-06-23 11:34 ` [PATCH 02/11] x86/efi: Consolidate region mapping logic Matt Fleming
2016-06-23 14:00 ` Borislav Petkov
2016-06-23 11:34 ` [PATCH 04/11] efi: Add efi_memmap_init_late() for permanent EFI memmap Matt Fleming
2016-06-23 11:34 ` [PATCH 05/11] efi/fake_mem: Refactor main two code chunks into functions Matt Fleming
2016-06-23 11:34 ` [PATCH 08/11] efi: Allow drivers to reserve boot services forever Matt Fleming
2016-06-23 11:34 ` [PATCH 10/11] efi/esrt: Use efi_mem_reserve() and avoid a kmalloc() Matt Fleming
2016-06-23 11:34 ` Matt Fleming [this message]
[not found] ` <1466681690-5850-12-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-06-30 14:41 ` [PATCH 11/11] x86/efi-bgrt: Use efi_mem_reserve() to avoid copying image data Josh Triplett
[not found] ` <1466681690-5850-1-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-06-23 11:34 ` [PATCH 03/11] efi: Refactor efi_memmap_init_early() into arch-neutral code Matt Fleming
[not found] ` <1466681690-5850-4-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-06-24 11:44 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_n9eVL6mNtrLQWdCwde9oLfkGYV5CnqLhSPO31Aehpzw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-04 12:19 ` Matt Fleming
[not found] ` <20160704121952.GK8415-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-07-04 22:24 ` Ard Biesheuvel
2016-06-23 11:34 ` [PATCH 06/11] efi: Split out EFI memory map functions into new file Matt Fleming
2016-06-23 11:34 ` [PATCH 07/11] efi: Add efi_memmap_install() for installing new EFI memory maps Matt Fleming
2016-06-23 11:34 ` [PATCH 09/11] efi/runtime-map: Use efi.memmap directly instead of a copy Matt Fleming
2016-06-30 14:34 ` [PATCH 00/11] efi: Permanent runtime EFI memmap support Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466681690-5850-12-git-send-email-matt@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=josh@joshtriplett.org \
--cc=jwboyer@fedoraproject.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mark.rutland@arm.com \
--cc=me@moshe.nl \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).