From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Dave Young <dyoung@redhat.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
Taku Izumi <izumi.taku@jp.fujitsu.com>,
Tony Luck <tony.luck@intel.com>, Xishi Qiu <qiuxishi@huawei.com>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: [PATCH 01/11] x86/efi: Test for EFI_MEMMAP functionality when iterating EFI memmap
Date: Thu, 23 Jun 2016 12:34:40 +0100 [thread overview]
Message-ID: <1466681690-5850-2-git-send-email-matt@codeblueprint.co.uk> (raw)
In-Reply-To: <1466681690-5850-1-git-send-email-matt@codeblueprint.co.uk>
Both efi_find_mirror() and efi_fake_memmap() really want to know
whether the EFI memory map is available, not just whether the machine
was booted using EFI. efi_fake_memmap() even has a check for
EFI_MEMMAP at the start of the function.
Since we've already got other code that has this dependency, merge
everything under one if() conditional, and remove the now superfluous
check from efi_fake_memmap().
Cc: Taku Izumi <izumi.taku@jp.fujitsu.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>
Cc: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
---
arch/x86/kernel/setup.c | 13 ++++++-------
drivers/firmware/efi/fake_mem.c | 2 +-
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index c4e7b3991b60..1867fa8ff75e 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1096,17 +1096,16 @@ void __init setup_arch(char **cmdline_p)
memblock_set_current_limit(ISA_END_ADDRESS);
memblock_x86_fill();
- if (efi_enabled(EFI_BOOT)) {
+ if (efi_enabled(EFI_MEMMAP)) {
efi_fake_memmap();
efi_find_mirror();
- }
- /*
- * The EFI specification says that boot service code won't be called
- * after ExitBootServices(). This is, in fact, a lie.
- */
- if (efi_enabled(EFI_MEMMAP))
+ /*
+ * The EFI specification says that boot service code won't be
+ * called after ExitBootServices(). This is, in fact, a lie.
+ */
efi_reserve_boot_services();
+ }
/* preallocate 4k for mptable mpc */
early_reserve_e820_mpc_new();
diff --git a/drivers/firmware/efi/fake_mem.c b/drivers/firmware/efi/fake_mem.c
index 48430aba13c1..c437388a7b85 100644
--- a/drivers/firmware/efi/fake_mem.c
+++ b/drivers/firmware/efi/fake_mem.c
@@ -64,7 +64,7 @@ void __init efi_fake_memmap(void)
void *old, *new;
int i;
- if (!nr_fake_mem || !efi_enabled(EFI_MEMMAP))
+ if (!nr_fake_mem)
return;
/* count up the number of EFI memory descriptor */
--
2.7.3
next prev parent reply other threads:[~2016-06-23 11:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 11:34 [PATCH 00/11] efi: Permanent runtime EFI memmap support Matt Fleming
2016-06-23 11:34 ` Matt Fleming [this message]
2016-06-23 11:34 ` [PATCH 02/11] x86/efi: Consolidate region mapping logic Matt Fleming
2016-06-23 14:00 ` Borislav Petkov
2016-06-23 11:34 ` [PATCH 04/11] efi: Add efi_memmap_init_late() for permanent EFI memmap Matt Fleming
2016-06-23 11:34 ` [PATCH 05/11] efi/fake_mem: Refactor main two code chunks into functions Matt Fleming
2016-06-23 11:34 ` [PATCH 08/11] efi: Allow drivers to reserve boot services forever Matt Fleming
2016-06-23 11:34 ` [PATCH 10/11] efi/esrt: Use efi_mem_reserve() and avoid a kmalloc() Matt Fleming
2016-06-23 11:34 ` [PATCH 11/11] x86/efi-bgrt: Use efi_mem_reserve() to avoid copying image data Matt Fleming
[not found] ` <1466681690-5850-12-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-06-30 14:41 ` Josh Triplett
[not found] ` <1466681690-5850-1-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-06-23 11:34 ` [PATCH 03/11] efi: Refactor efi_memmap_init_early() into arch-neutral code Matt Fleming
[not found] ` <1466681690-5850-4-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-06-24 11:44 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_n9eVL6mNtrLQWdCwde9oLfkGYV5CnqLhSPO31Aehpzw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-04 12:19 ` Matt Fleming
[not found] ` <20160704121952.GK8415-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-07-04 22:24 ` Ard Biesheuvel
2016-06-23 11:34 ` [PATCH 06/11] efi: Split out EFI memory map functions into new file Matt Fleming
2016-06-23 11:34 ` [PATCH 07/11] efi: Add efi_memmap_install() for installing new EFI memory maps Matt Fleming
2016-06-23 11:34 ` [PATCH 09/11] efi/runtime-map: Use efi.memmap directly instead of a copy Matt Fleming
2016-06-30 14:34 ` [PATCH 00/11] efi: Permanent runtime EFI memmap support Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466681690-5850-2-git-send-email-matt@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=dyoung@redhat.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiuxishi@huawei.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).