From: Petr Oros <poros-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
Cc: ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] x86/efi Fix regression in efi_arch_mem_reserve
Date: Thu, 22 Dec 2016 11:21:47 +0100 [thread overview]
Message-ID: <1482402107.3184.3.camel@redhat.com> (raw)
In-Reply-To: <20161221223054.GG2225-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
Matt Fleming píše v Wed 21. 12. 2016 v 22:30 +0000:
> On Wed, 21 Dec, at 02:11:38PM, Petr Oros wrote:
> >
> > Booting on EFI with ESRT table has been stop since commit:
> > 8e80632 efi/esrt: Use efi_mem_reserve() and avoid a kmalloc()
> >
> > This is caused by this commit:
> > 816e761 efi: Allow drivers to reserve boot services forever
> >
> > Problem is, that efi_memmap_insert need memory aligned
> > on EFI_PAGE_SIZE. If memory not aligned, efi_memmap_insert
> > just return and let efi.memmap in inconsistent state.
> > This breaking boot.
> >
> > Tested in my machine, which stop booting
> > after upgrade to 4.9
> >
> > Signed-off-by: Petr Oros <poros-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > ---
> > arch/x86/platform/efi/quirks.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Could you provide some more information? Why does efi_memmap_insert()
> require this alignment? How does booting "break"? If you see an Oops,
> please post it here.
Ooops, sorry, please ignore this patch. I overlooked efi_memmap_insert
argument order. I bisected kernel and this patch breaking kernel boot
but from other reason. Provided patch fixed kernel booting issue by
mistake.
-Petr
prev parent reply other threads:[~2016-12-22 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 13:11 [PATCH] x86/efi Fix regression in efi_arch_mem_reserve Petr Oros
2016-12-21 22:30 ` Matt Fleming
[not found] ` <20161221223054.GG2225-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-12-22 10:21 ` Petr Oros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482402107.3184.3.camel@redhat.com \
--to=poros-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).