[PATCH v2] x86/efi: Clean up a minor mistake in code comment

[PATCH v2] x86/efi: Clean up a minor mistake in code comment

[Baoquan He]

EFI allocate runtime services regions from EFI_VA_START, -4G, down
to -68G, EFI_VA_END, 64G altogether. The mechanism was introduced in
commit d2f7cbe7b26a7 ("x86/efi: Runtime services virtual mapping").

Clean it up to avoid confusion.

Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
v1->v2:
  Update patch log to corret a description mistake Ard pointed out.

 arch/x86/platform/efi/efi_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
index a4695da..6cbf9e0 100644
--- a/arch/x86/platform/efi/efi_64.c
+++ b/arch/x86/platform/efi/efi_64.c
@@ -47,7 +47,7 @@
 #include <asm/pgalloc.h>
 
 /*
- * We allocate runtime services regions bottom-up, starting from -4G, i.e.
+ * We allocate runtime services regions top-down, starting from -4G, i.e.
  * 0xffff_ffff_0000_0000 and limit EFI VA mapping space to 64G.
  */
 static u64 efi_va = EFI_VA_START;
-- 
2.5.5

Re: [PATCH v2] x86/efi: Clean up a minor mistake in code comment

[Ard Biesheuvel]

On 24 March 2017 at 09:17, Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> EFI allocate runtime services regions from EFI_VA_START, -4G, down
> to -68G, EFI_VA_END, 64G altogether. The mechanism was introduced in
> commit d2f7cbe7b26a7 ("x86/efi: Runtime services virtual mapping").
>
> Clean it up to avoid confusion.
>
> Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> v1->v2:
>   Update patch log to corret a description mistake Ard pointed out.
>

Queued in efi/next for v4.12

Thanks,
Ard.

Re: [PATCH v2] x86/efi: Clean up a minor mistake in code comment

[Baoquan He]

On 03/24/17 at 09:43am, Ard Biesheuvel wrote:
> On 24 March 2017 at 09:17, Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> > EFI allocate runtime services regions from EFI_VA_START, -4G, down
> > to -68G, EFI_VA_END, 64G altogether. The mechanism was introduced in
> > commit d2f7cbe7b26a7 ("x86/efi: Runtime services virtual mapping").
> >
> > Clean it up to avoid confusion.
> >
> > Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > ---
> > v1->v2:
> >   Update patch log to corret a description mistake Ard pointed out.
> >
> 
> Queued in efi/next for v4.12

Thanks, Ard!

Baoquan