From: Stefan Haberland <sth@linux.ibm.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Jan Hoeppner <hoeppner@linux.ibm.com>,
"Richard Russon (FlatCap)" <ldm@flatcap.org>,
linux-block@vger.kernel.org, linux-efi@vger.kernel.org,
linux-s390@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net
Subject: Re: [PATCH 1/4] block: store a gendisk in struct parsed_partitions
Date: Thu, 12 Aug 2021 16:21:12 +0200 [thread overview]
Message-ID: <15ddb7b3-8b43-2e36-652c-c6ccb06c7f88@linux.ibm.com> (raw)
In-Reply-To: <20210810154512.1809898-2-hch@lst.de>
Am 10.08.21 um 17:45 schrieb Christoph Hellwig:
> Partition scanning only happens on the whole device, so pass a
> struct gendisk instead of the whole device block_device to the scanners.
> This allows to simplify printing the device name in various places as the
> disk name is available in disk->name.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/partitions/acorn.c | 4 ++--
> block/partitions/aix.c | 20 ++------------------
> block/partitions/amiga.c | 7 +++----
> block/partitions/atari.c | 4 ++--
> block/partitions/check.h | 2 +-
> block/partitions/cmdline.c | 6 ++----
> block/partitions/core.c | 6 +++---
> block/partitions/efi.c | 36 +++++++++++++++++-------------------
> block/partitions/ibm.c | 4 ++--
for the DASD part:
Looks good.
Reviewed-by: Stefan Haberland <sth@linux.ibm.com>
next prev parent reply other threads:[~2021-08-12 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 15:45 pass a gendisk instead of block_device in the partitioning code Christoph Hellwig
2021-08-10 15:45 ` [PATCH 1/4] block: store a gendisk in struct parsed_partitions Christoph Hellwig
2021-08-12 14:21 ` Stefan Haberland [this message]
2021-08-10 15:45 ` [PATCH 2/4] block: pass a gendisk to bdev_add_partition Christoph Hellwig
2021-08-10 15:45 ` [PATCH 3/4] block: pass a gendisk to bdev_del_partition Christoph Hellwig
2021-08-10 15:45 ` [PATCH 4/4] block: pass a gendisk to bdev_resize_partition Christoph Hellwig
2021-08-12 16:51 ` pass a gendisk instead of block_device in the partitioning code Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15ddb7b3-8b43-2e36-652c-c6ccb06c7f88@linux.ibm.com \
--to=sth@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=hch@lst.de \
--cc=hoeppner@linux.ibm.com \
--cc=ldm@flatcap.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox