From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Ben Dooks" <ben.dooks@codethink.co.uk>, linux-efi@vger.kernel.org
Cc: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi: libstub: fix type of fdt 32 and 64bit variables
Date: Tue, 10 Mar 2026 15:38:05 +0100 [thread overview]
Message-ID: <1679cc1e-df84-4067-905b-332ea0a92aa9@app.fastmail.com> (raw)
In-Reply-To: <20260309171012.2909693-1-ben.dooks@codethink.co.uk>
On Mon, 9 Mar 2026, at 18:10, Ben Dooks wrote:
> In update_fdt_memmap() an update_fdt() the fdt values should be
> of the fd32_t and fdt64_t types. Make the relevant changes to
> remove the following sparse warnings:
>
> drivers/firmware/efi/libstub/fdt.c:97:19: warning: incorrect type in
> assignment (different base types)
> drivers/firmware/efi/libstub/fdt.c:97:19: expected unsigned long
> long [usertype] fdt_val64
> drivers/firmware/efi/libstub/fdt.c:97:19: got restricted __be64
> [usertype]
> drivers/firmware/efi/libstub/fdt.c:157:19: warning: incorrect type in
> assignment (different base types)
> drivers/firmware/efi/libstub/fdt.c:157:19: expected unsigned long
> long [usertype] fdt_val64
> drivers/firmware/efi/libstub/fdt.c:157:19: got restricted __be64
> [usertype]
> drivers/firmware/efi/libstub/fdt.c:163:19: warning: incorrect type in
> assignment (different base types)
> drivers/firmware/efi/libstub/fdt.c:163:19: expected unsigned int
> [usertype] fdt_val32
> drivers/firmware/efi/libstub/fdt.c:163:19: got restricted __be32
> [usertype]
> drivers/firmware/efi/libstub/fdt.c:169:19: warning: incorrect type in
> assignment (different base types)
> drivers/firmware/efi/libstub/fdt.c:169:19: expected unsigned int
> [addressable] [usertype] fdt_val32
> drivers/firmware/efi/libstub/fdt.c:169:19: got restricted __be32
> [usertype]
> drivers/firmware/efi/libstub/fdt.c:175:19: warning: incorrect type in
> assignment (different base types)
> drivers/firmware/efi/libstub/fdt.c:175:19: expected unsigned int
> [addressable] [usertype] fdt_val32
> drivers/firmware/efi/libstub/fdt.c:175:19: got restricted __be32
> [usertype]
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> drivers/firmware/efi/libstub/fdt.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
Queued up in efi/next - thanks.
prev parent reply other threads:[~2026-03-10 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 17:10 [PATCH] efi: libstub: fix type of fdt 32 and 64bit variables Ben Dooks
2026-03-10 14:38 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1679cc1e-df84-4067-905b-332ea0a92aa9@app.fastmail.com \
--to=ardb@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox