From: Rob Herring <robh@kernel.org>
To: Romain Gantois <romain.gantois@bootlin.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Davidlohr Bueso <dave@stgolabs.net>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
linux-block@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
Jens Axboe <axboe@kernel.dk>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-efi@vger.kernel.org, Richard Weinberger <richard@nod.at>
Subject: Re: [RFC PATCH 6/6] dt-bindings: mtd: add GPT partition bindings
Date: Mon, 11 Dec 2023 10:21:26 -0600 [thread overview]
Message-ID: <170231168656.2365852.16098091734582168376.robh@kernel.org> (raw)
In-Reply-To: <20231211151244.289349-7-romain.gantois@bootlin.com>
On Mon, 11 Dec 2023 16:12:42 +0100, Romain Gantois wrote:
> Allow parsing GPT layouts on MTD devices.
>
> Signed-off-by: Romain Gantois <romain.gantois@bootlin.com>
> ---
> .../bindings/mtd/partitions/gpt.yaml | 41 +++++++++++++++++++
> .../bindings/mtd/partitions/partitions.yaml | 1 +
> 2 files changed, 42 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/partitions/gpt.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/mtd/partitions/gpt.yaml:11:1: [error] syntax error: could not find expected ':' (syntax)
dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/mtd/partitions/gpt.example.dts'
Documentation/devicetree/bindings/mtd/partitions/gpt.yaml:11:1: could not find expected ':'
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/mtd/partitions/gpt.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml:
while scanning a simple key
in "<unicode string>", line 10, column 1
could not find expected ':'
in "<unicode string>", line 11, column 1
./Documentation/devicetree/bindings/mtd/partitions/gpt.yaml:11:1: could not find expected ':'
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/partitions/gpt.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1424: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231211151244.289349-7-romain.gantois@bootlin.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-12-11 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 15:12 [RFC PATCH 0/6] Add GPT parser to MTD layer Romain Gantois
2023-12-11 15:12 ` [RFC PATCH 1/6] block: partitions: efi: Move efi.h header to include/linux/gpt.h Romain Gantois
2023-12-11 15:12 ` [RFC PATCH 2/6] block: partitions: efi: Fix some style issues Romain Gantois
2023-12-12 0:57 ` Davidlohr Bueso
2023-12-11 15:12 ` [RFC PATCH 3/6] block: partitions: efi: Separate out GPT-specific code Romain Gantois
2023-12-11 15:12 ` [RFC PATCH 4/6] block: partitions: efi: Move GPT-specific code to a new library Romain Gantois
2023-12-11 15:12 ` [RFC PATCH 5/6] drivers: mtd: introduce GPT parser for NOR flash devices Romain Gantois
2023-12-11 15:12 ` [RFC PATCH 6/6] dt-bindings: mtd: add GPT partition bindings Romain Gantois
2023-12-11 16:21 ` Rob Herring [this message]
2023-12-12 0:43 ` [RFC PATCH 0/6] Add GPT parser to MTD layer Davidlohr Bueso
2023-12-14 10:34 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170231168656.2365852.16098091734582168376.robh@kernel.org \
--to=robh@kernel.org \
--cc=ardb@kernel.org \
--cc=axboe@kernel.dk \
--cc=conor+dt@kernel.org \
--cc=dave@stgolabs.net \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox