From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0838FC433EF for ; Wed, 8 Jun 2022 10:15:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236595AbiFHKPf (ORCPT ); Wed, 8 Jun 2022 06:15:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236312AbiFHKOx (ORCPT ); Wed, 8 Jun 2022 06:14:53 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A6632264459; Wed, 8 Jun 2022 03:02:48 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 009ED143D; Wed, 8 Jun 2022 03:02:48 -0700 (PDT) Received: from [10.162.41.25] (unknown [10.162.41.25]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 491583F800; Wed, 8 Jun 2022 03:02:35 -0700 (PDT) Message-ID: <1c1a384e-3d58-0434-3ab1-61160cd00970@arm.com> Date: Wed, 8 Jun 2022 15:32:28 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 3/6] mm: Ratelimited mirrored memory related warning messages Content-Language: en-US To: Wupeng Ma , corbet@lwn.net, will@kernel.org, ardb@kernel.org, catalin.marinas@arm.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, dvhart@infradead.org, andy@infradead.org, rppt@kernel.org, akpm@linux-foundation.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, paulmck@kernel.org, keescook@chromium.org, songmuchun@bytedance.com, rdunlap@infradead.org, damien.lemoal@opensource.wdc.com, swboyd@chromium.org, wei.liu@kernel.org, robin.murphy@arm.com, david@redhat.com, thunder.leizhen@huawei.com, wangkefeng.wang@huawei.com, gpiccoli@igalia.com, chenhuacai@kernel.org, geert@linux-m68k.org, chenzhou10@huawei.com, vijayb@linux.microsoft.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org References: <20220607093805.1354256-1-mawupeng1@huawei.com> <20220607093805.1354256-4-mawupeng1@huawei.com> From: Anshuman Khandual In-Reply-To: <20220607093805.1354256-4-mawupeng1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On 6/7/22 15:08, Wupeng Ma wrote: > From: Ma Wupeng > > If system has mirrored memory, memblock will try to allocate mirrored > memory firstly and fallback to non-mirrored memory when fails, but if with > limited mirrored memory or some numa node without mirrored memory, lots of > warning message about memblock allocation will occur. > > This patch ratelimit the warning message to avoid a very long print during > bootup. > > Signed-off-by: Ma Wupeng > --- > mm/memblock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index e4f03a6e8e56..b1d2a0009733 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -327,7 +327,7 @@ static phys_addr_t __init_memblock memblock_find_in_range(phys_addr_t start, > NUMA_NO_NODE, flags); > > if (!ret && (flags & MEMBLOCK_MIRROR)) { > - pr_warn("Could not allocate %pap bytes of mirrored memory\n", > + pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n", > &size); > flags &= ~MEMBLOCK_MIRROR; > goto again; > @@ -1384,7 +1384,7 @@ phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > > if (flags & MEMBLOCK_MIRROR) { > flags &= ~MEMBLOCK_MIRROR; > - pr_warn("Could not allocate %pap bytes of mirrored memory\n", > + pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n", > &size); > goto again; > } Reviewed-by: Anshuman Khandual