From: Lennart Poettering <lennart@poettering.net>
To: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
Cc: linux-efi@vger.kernel.org, systemd-devel@lists.freedesktop.org,
Kay Sievers <kay@vrfy.org>, "Lee, Chun-Yi" <jlee@suse.com>,
Matt Fleming <matt.fleming@intel.com>,
Jeremy Kerr <jeremy.kerr@canonical.com>,
Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH] Add syste-firmware-efi-efivars.mount for support automount EFI variable filesystem
Date: Wed, 24 Oct 2012 16:04:02 +0200 [thread overview]
Message-ID: <20121024140401.GA19778@tango.0pointer.de> (raw)
In-Reply-To: <1351075322-3824-1-git-send-email-jlee@suse.com>
On Wed, 24.10.12 18:42, Lee, Chun-Yi (joeyli.kernel@gmail.com) wrote:
> Add units/sys-firmware-efi-efivars.mount rule for support automount
> EFI variable filesystem
Good in principle, but as Kay mentioned we probably should not expose
this as units, but just mount it from PID1's C code. More specifically
add it to the table in src/core/mount-setup.c, but make sure to set the
"fatal" bool in the table to false for this entry, to clarify that this
is not a reason to fail.
You probably also want to add the kmod to the table in
src/core/kmod-setup.c since the mount point is not available if the kmod
is not loaded.
Thanks!
Lennart
--
Lennart Poettering - Red Hat, Inc.
next prev parent reply other threads:[~2012-10-24 14:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 10:42 [PATCH] Add syste-firmware-efi-efivars.mount for support automount EFI variable filesystem Lee, Chun-Yi
[not found] ` <1351075322-3824-1-git-send-email-jlee-IBi9RG/b67k@public.gmane.org>
2012-10-24 11:07 ` [systemd-devel] " Mantas Mikulėnas
[not found] ` <CAPWNY8VVtW6C6gmXBcJBbKeQ+YVTUvFx2xynP0mknr68uJO_SQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-24 11:32 ` joeyli
[not found] ` <1351078348.30067.31.camel-ONCj+Eqt86TasUa73XJKwA@public.gmane.org>
2012-10-24 11:34 ` joeyli
2012-10-24 12:12 ` Zbigniew Jędrzejewski-Szmek
[not found] ` <20121024121246.GU19454-wrcVdnn0TatmR6Xm/wNWPw@public.gmane.org>
2012-10-24 12:17 ` [systemd-devel] " Kay Sievers
[not found] ` <CAPXgP10Jejdu6Q=4XDy0ujjX6kKX-efgCZxmPJJiV5YRfNCJ6Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-24 12:23 ` Zbigniew Jędrzejewski-Szmek
[not found] ` <20121024122337.GV19454-wrcVdnn0TatmR6Xm/wNWPw@public.gmane.org>
2012-10-24 13:00 ` Kay Sievers
[not found] ` <CAPXgP11ov-2W=189WeT2jN5KDzu3CpSb5rJG=3s1AZ0W1YT+qQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-24 13:09 ` Zbigniew Jędrzejewski-Szmek
[not found] ` <20121024130944.GW19454-wrcVdnn0TatmR6Xm/wNWPw@public.gmane.org>
2012-10-24 13:22 ` Kay Sievers
2012-10-24 14:04 ` Lennart Poettering [this message]
[not found] ` <20121024140401.GA19778-kS5D54t9nk0aINubkmmoJbNAH6kLmebB@public.gmane.org>
2012-10-25 4:12 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024140401.GA19778@tango.0pointer.de \
--to=lennart@poettering.net \
--cc=jeremy.kerr@canonical.com \
--cc=jlee@suse.com \
--cc=joeyli.kernel@gmail.com \
--cc=kay@vrfy.org \
--cc=linux-efi@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mjg@redhat.com \
--cc=systemd-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox