Linux EFI development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Matt Fleming <matt@console-pimps.org>
Cc: Corentin Chary <corentincj@iksaif.net>,
	Matthew Garrett <mjg@redhat.com>,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	Alessandro Crismani <alessandro.crismani@gmail.com>,
	Mikhail Bakhterev <mike.bakhterev@gmail.com>,
	Patrick H <kernel@feystorm.net>,
	Matt Fleming <matt.fleming@intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] samsung-laptop: Disable if CONFIG_EFI=y
Date: Mon, 5 Nov 2012 11:37:53 +0100	[thread overview]
Message-ID: <20121105103753.GA25850@kroah.com> (raw)
In-Reply-To: <1352050506-29317-1-git-send-email-matt@console-pimps.org>

On Sun, Nov 04, 2012 at 05:35:06PM +0000, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@intel.com>
> 
> We've started getting reports of users seeing Machine Check Exceptions
> when booting their Samsung laptops in UEFI mode,
> 
>      https://bugzilla.kernel.org/show_bug.cgi?id=47121
> 
> This module seems to be the culprit as it's grovelling around in the
> 0xf0000 region which has no mapping in either the e820 or EFI memory
> maps on the affected machines.

So, does this mean that if we try to ioremap a memory location in the
kernel, like this driver is, it will not fail, but, when accessing the
memory, bad things happen?

That's not good, shouldn't the call to ioremap_nocache() have failed
originally?  That sounds like a core EFI/platform bug here, and one that
you might run into other places.

Shouldn't fixing that be the real fix?


thanks,

greg k-h

  parent reply	other threads:[~2012-11-05 10:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-04 17:35 [PATCH] samsung-laptop: Disable if CONFIG_EFI=y Matt Fleming
2012-11-04 17:44 ` Corentin Chary
     [not found]   ` <CAHR064isMXk8qkqhBJ==9sRRP7xC_j_K5rqXApza-LNkosp5mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-04 19:37     ` Alan Cox
2012-11-05  9:12       ` Corentin Chary
2012-11-05 10:30         ` Greg KH
2012-11-05 11:50           ` Matt Fleming
2012-11-05 12:07             ` Alan Cox
2012-11-05 12:09               ` Matt Fleming
2012-11-05 12:12       ` Matt Fleming
2012-11-05 12:13   ` Matt Fleming
2012-11-04 17:47 ` Jonathan Nieder
     [not found]   ` <20121104174713.GA28414-fcEM2ccDkbL2nhBuCrrZHw@public.gmane.org>
2012-11-04 20:58     ` Matt Fleming
2012-11-05 10:37 ` Greg KH [this message]
2012-11-05 12:09   ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121105103753.GA25850@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alessandro.crismani@gmail.com \
    --cc=corentincj@iksaif.net \
    --cc=hpa@zytor.com \
    --cc=kernel@feystorm.net \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=matt@console-pimps.org \
    --cc=mike.bakhterev@gmail.com \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox