From: Josh Triplett <josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>
To: Jan Beulich <JBeulich-IBi9RG/b67k@public.gmane.org>
Cc: mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
mingo-X9Un+BFzKDI@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] x86/EFI: additional checks in efi_bgrt_init()
Date: Mon, 5 Nov 2012 10:37:52 -0800 [thread overview]
Message-ID: <20121105183751.GA9031@jtriplet-mobl1> (raw)
In-Reply-To: <5097E8C102000078000A661B-ce6RLXgGx+vWGUEhTRrCg1aTQe2KTcn/@public.gmane.org>
On Mon, Nov 05, 2012 at 03:26:41PM +0000, Jan Beulich wrote:
> Header length should be validated for all ACPI tables before accessing
> any non-header field.
>
> The valid flags should also be check, as with it clear there's no point
> in trying to go through the rest of the code (and there's no guarantee
> that the other table contents are valid/consistent in that case).
>
> Signed-off-by: Jan Beulich <jbeulich-IBi9RG/b67k@public.gmane.org>
The length check seems reasonable. However, Matthew Garrett (already
CCed) previously suggested to me that this code should not check the
"valid" bit, and should instead present the information to userspace if
otherwise valid (such as having image_address != 0). Matthew?
Out of curiosity, did you encounter a system that requires this patch?
- Josh Triplett
next prev parent reply other threads:[~2012-11-05 18:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 15:26 [PATCH] x86/EFI: additional checks in efi_bgrt_init() Jan Beulich
[not found] ` <5097E8C102000078000A661B-ce6RLXgGx+vWGUEhTRrCg1aTQe2KTcn/@public.gmane.org>
2012-11-05 18:37 ` Josh Triplett [this message]
2012-11-05 18:43 ` Matthew Garrett
[not found] ` <20121105184346.GA13508-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2012-11-05 19:00 ` Josh Triplett
2012-11-06 8:57 ` Jan Beulich
[not found] ` <5098DEF202000078000A695F-ce6RLXgGx+vWGUEhTRrCg1aTQe2KTcn/@public.gmane.org>
2012-11-06 12:55 ` Josh Triplett
2012-11-06 13:37 ` Jan Beulich
[not found] ` <5099209602000078000A6B3C-ce6RLXgGx+vWGUEhTRrCg1aTQe2KTcn/@public.gmane.org>
2012-11-06 16:16 ` Josh Triplett
2012-11-07 14:48 ` Jan Beulich
[not found] ` <509A82E402000078000A6FC8-ce6RLXgGx+vWGUEhTRrCg1aTQe2KTcn/@public.gmane.org>
2012-11-07 14:52 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121105183751.GA9031@jtriplet-mobl1 \
--to=josh-iaamlnmf4umaiuxdjuqwma@public.gmane.org \
--cc=JBeulich-IBi9RG/b67k@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
--cc=mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox