From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russ Anderson Subject: Re: [regression, bisected] x86: efi: Pass boot services variable info to runtime code Date: Thu, 30 May 2013 21:17:49 -0500 Message-ID: <20130531021749.GA24287@sgi.com> References: <20130524074331.GL14575@console-pimps.org> <20130529210115.GC28027@sgi.com> <20130529224645.GA16582@sgi.com> <1369880172.17397.11.camel@linux-s257.site> <20130530221737.GA11105@sgi.com> <1369952512.11620.14.camel@x230> <20130530222836.GB11105@sgi.com> Reply-To: Russ Anderson Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jiri Kosina Cc: Matthew Garrett , joeyli , Matt Fleming , "matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Borislav Petkov List-Id: linux-efi@vger.kernel.org On Fri, May 31, 2013 at 12:30:43AM +0200, Jiri Kosina wrote: > On Thu, 30 May 2013, Russ Anderson wrote: > > > > > That's a great idea. This patch moves the QueryVariableInfo() > > > > call from bootime to runtime, in efi_late_init(). The attached > > > > patch is consistent with the UEFI spec and avoids the problem. > > > > > > No, that defeats the entire point of the original patch. > > > > How so? It is still calling QueryVariableInfo() > > before the data is used. > > You lose information provided by QueryVariableInfo() about boot-only > variables once the transition boot -> runtime has happened. Is that information really more important than the ability to boot? Correct me if I'm wrong, but linux was able to boot without the boottime QueryVariableInfo() call up until 3.9-rc7, and it still does on systems that do not use EFI stubs (ie grub and elilo). It is only when linux uses EFI stubs (ie grub2) that linux makes the boottime QueryVariableInfo() call. So why is that call, or whatever is dependent on it, more important than booting? Thanks, -- Russ Anderson, OS RAS/Partitioning Project Lead SGI - Silicon Graphics Inc rja-sJ/iWh9BUns@public.gmane.org