From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russ Anderson Subject: Re: [regression, bisected] x86: efi: Pass boot services variable info to runtime code Date: Thu, 30 May 2013 21:54:38 -0500 Message-ID: <20130531025438.GB24287@sgi.com> References: <20130524074331.GL14575@console-pimps.org> <20130529210115.GC28027@sgi.com> <20130529224645.GA16582@sgi.com> <1369880172.17397.11.camel@linux-s257.site> <20130530221737.GA11105@sgi.com> <1369952512.11620.14.camel@x230> <20130530222836.GB11105@sgi.com> <1369953129.11620.15.camel@x230> Reply-To: Russ Anderson Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1369953129.11620.15.camel@x230> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matthew Garrett Cc: joeyli , Jiri Kosina , Matt Fleming , "matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Borislav Petkov List-Id: linux-efi@vger.kernel.org On Thu, May 30, 2013 at 10:32:09PM +0000, Matthew Garrett wrote: > On Thu, 2013-05-30 at 17:28 -0500, Russ Anderson wrote: > > On Thu, May 30, 2013 at 10:21:53PM +0000, Matthew Garrett wrote: > > > On Thu, 2013-05-30 at 17:17 -0500, Russ Anderson wrote: > > > > > > > That's a great idea. This patch moves the QueryVariableInfo() > > > > call from bootime to runtime, in efi_late_init(). The attached > > > > patch is consistent with the UEFI spec and avoids the problem. > > > > > > No, that defeats the entire point of the original patch. > > > > How so? It is still calling QueryVariableInfo() > > before the data is used. > > We want to know how much space is used by variables that aren't visible > at runtime. We want to boot. We could boot up through 3.9-rc7. Knowing how much space is used by variables that aren't visible at runtime it moot if you can't boot. And again, maybe this is a bios bug - we have bios people looking into it - and maybe that call _should_ work, but the fact is the kernel booted without that change[1] and does not boot with it. [1] commit cc5a080c5d40c36089bb08a8a16fa3fc7047fe0f Thanks, -- Russ Anderson, OS RAS/Partitioning Project Lead SGI - Silicon Graphics Inc rja-sJ/iWh9BUns@public.gmane.org