Re: [PATCH 0/4] EFI 1:1 mapping

James Bottomley
2013-06-03T14:38:02Z

On Mon, 2013-06-03 at 15:30 +0100, Matthew Garrett wrote:
> On Mon, Jun 03, 2013 at 07:27:22AM -0700, James Bottomley wrote:
>
> > That's correct. I think not calling SetVirtualAddressMap() and just
> > using a 1:1 mapping is far safer (having looked at what tianocore does
> > for SetVirtualAddressMap()). The chances are that all the UEFI bioses
> > are only tested with windows, so the pointer chases it has to do to
> > switch address maps only work with the operations windows does.
>
> Windows calls SetVirtualAddressMap(), so the only way these systems have
> been tested is with SetVirtualAddressMap().

I know, but that's not what I said.

If you look at the implementation, SetVirtualAddressMap() does a massive
pointer chase through the images. It not only tries to relocate the
text and data, but it also tries to relocate all the users of the data.
Some of these sources of data are boot time and some runtime. Those
both need to be relocated by a separate pointer chase. What we saw with
the QueryVariableInfo() problem was that a boot time pointer wasn't
relocated. That's got to mean that windows only calls QueryVariableInfo
from runtime.

My point is that if we elect to call SetVirtualAddressMap() we'll be
restricted to only making the calls at boot time that windows does
otherwise we'll end up with these unrelocated pointers. That's a huge
nasty verification burden on us. Alternatively, if we never call
SetVirtualAddressMap() it seems to me that we just don't have to worry
about pointer relocation issues. Thus, I think it would be better we
use the 1:1 mapping instead of calling SetVirtualAddressMap().

James