Re: [PATCH 3/4] x86, efi: Add an efi= kernel command line parameter

Matt Fleming
2013-06-06T13:36:09Z

On Thu, 06 Jun, at 03:26:03PM, Borislav Petkov wrote:
> On Thu, Jun 06, 2013 at 11:42:24AM +0100, Matt Fleming wrote:
> > On Sun, 02 Jun, at 02:56:09PM, Borislav Petkov wrote:
> > > +
> > > +static int __init parse_efi_cmdline(char *str)
> > > +{
> > > + if (*str == '=')
> > > + str++;
> > > + if (!strncmp(str, "1:1_map", 7))
> > > + efi_config |= EFI_CFG_MAP11;
> > > +
> > > + return 0;
> > > +}
> > > +early_param("efi", parse_efi_cmdline);
> >
> > This is fine for testing, but I genuinely think that this should be on
> > by default once these patches are final.
>
> This would break the Macs, remember?
>
> We could make it be the default though and flip the logic so that users
> can fall back to the current ioremap functionality, i.e. boot with
> "efi=no_1:1_map".

Yeah, or white/blacklist them. We've already had enough of "Oh, your
machine used to work but now it's bust? Yeah, turn on this cmdline
parameter to get things working again".

But the point is that the funnies that have been seen on the Macs should
be treated as the unusual case. The number of machines I've seen that
require this 1:1 map is staggering, especially once you start poking at
some of the other runtime services, like UpdateCapsule().

--
Matt Fleming, Intel Open Source Technology Center