Re: [PATCH 2/4] x86, cpa: Map in an arbitrary pgd

Borislav Petkov
2013-06-06T13:24:06Z

On Thu, Jun 06, 2013 at 11:22:33AM +0100, Matt Fleming wrote:
> > @@ -697,7 +714,10 @@ static int __change_page_attr(struct cpa_data *cpa, int primary)
> > else
> > address = *cpa->vaddr;
> > repeat:
> > - kpte = lookup_address(address, &level);
> > + if (cpa->pgd)
> > + kpte = __lookup_address_in_pgd(cpa->pgd, address, &level);
> > + else
> > + kpte = _lookup_address_cpa(cpa, address, &level);
>
> Don't you also need to initialise .pgd in __set_pages_p() and
> __set_pages_np()?

Hmm, I don't think so. The idea is to leave the current functionality in
pageattr.c untouched. Currently, it maps PTEs in init_mm.pgd by default
because this is the kernel PGD.

For EFI, we switch the PGD and we want to map the PTEs in this other
PGD, thus we have our own kernel_map_pages_in_pgd() which passes in the
PGD we want to map in through struct cpa_data.

Then, we differentiate the PGD down that code by looking at cpa->pgd.

This was at least the idea.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--