Re: [PATCH] Remove redundant and incorrect memset()

[Ingo Molnar <mingo@kernel.org>]

* Roy Franz <roy.franz@linaro.org> wrote:

> On Oct 4, 2013 1:33 PM, "Ingo Molnar" <mingo@kernel.org> wrote:
> >
> >
> > * Roy Franz <roy.franz@linaro.org> wrote:
> >
> > > Remove a redundant memset() call from efi_relocate_kernel() that
> > > was clearing memory that would be used by BSS in non-compressed
> > > images loaded with this function.  This clear was redundant with
> > > the clearing done in the image itself, and also implemented incorrectly
> > > with a 0 length.
> > >
> > > Signed-off-by: Roy Franz <roy.franz@linaro.org>
> > > Acked-by: Mark Salter <msalter@redhat.com>
> >
> > Note the title:
> >
> >    [PATCH] Remove redundant and incorrect memset()
> >
> > if it's both redundant *and* incorrect then the other memset() must be
> > incorrect too and must be removed as well ;-)
> >
> > I suspect you wanted the title to say:
> >
> >    [PATCH] Remove redundant memset()
> >
> > ?
> >
> > Thanks,
> >
> >         Ingo
> Hi Ingo,
> 
>   The memset being removed is redundant  with a correctly implemented
> memset in the kernel itself.   The memset being removed is also incorrect,
> with a hard coded length of 0.

So it was redundantly clearing nothing? ;-)

Anyway, I agree, the title makes sense.

Thanks,

	Ingo