From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Jones Subject: Re: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support Date: Thu, 10 Oct 2013 13:37:10 -0400 Message-ID: <20131010173710.GA18821@fenchurch.internal.datastacks.com> References: <1381423261-30566-1-git-send-email-matt@console-pimps.org> <20131010172844.GA26430@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20131010172844.GA26430-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ingo Molnar Cc: Matt Fleming , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matt Fleming , "H. Peter Anvin" , Thomas Gleixner List-Id: linux-efi@vger.kernel.org On Thu, Oct 10, 2013 at 07:28:44PM +0200, Ingo Molnar wrote: > > Is a non-32-bit framebuffer a possibility? If yes then it might be nice to > emit an informative printk() here, so that users who try to enable EFI > early-printk can at least see why it's not working. (Assuming they get to > look at regular printk output, on a safe/working kernel.) Not really - the spec allows RGBx, BGRx, and for custom bit masks, but they're define like: typedef struct { UINT32 RedMask; UINT32 GreenMask; UINT32 BlueMask; UINT32 ReservedMask; } EFI_PIXEL_BITMASK; -- Peter