From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support Date: Mon, 14 Oct 2013 09:57:26 +0200 Message-ID: <20131014075726.GB20435@gmail.com> References: <1381423261-30566-1-git-send-email-matt@console-pimps.org> <20131010172844.GA26430@gmail.com> <20131011140039.GF12321@console-pimps.org> <20131012174934.GA18849@gmail.com> <525B06CB.6090602@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <525B06CB.6090602-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "H. Peter Anvin" Cc: Matt Fleming , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matt Fleming , Thomas Gleixner , Peter Jones List-Id: linux-efi@vger.kernel.org * H. Peter Anvin wrote: > On 10/12/2013 10:49 AM, Ingo Molnar wrote: > > > >>>> +static void early_efi_write_char(void *dst, char c, int h) > >>>> +{ > >>>> + const u8 *src; > >>>> + u32 fgcolor = 0xaaaaaa; > >>> > >>> That's RGB grey, right? Why not 0xffffff for a very visible white? > >> > >> The VGA earlyprintk code uses the equivalent grey, AFAIK, which is why I > >> picked this value. > > > > The VGA code should be changed to white too I suspect ;-) > > > > For compatibility with the classical text console we use light grey as > the default color and a double-stroked font (which was necessary on the > CGA display since it didn't have enough bandwidth to handle > single-stroked fonts well). The problem with changing that to white is > that you end up with a mismatch between the earlyprintk console and the > "real" console, *or* we change the behavior of everyone's consoles... Btw., I have no problem at all with making the early console look separate and making it clear when we switch to the 'real' console. earlyprintk is a debug method, and more information can only be good. Thanks, Ingo