From: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
To: Seiji Aguchi <seiji.aguchi-7rDLJAbr9SE@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Tomoki Sekiyama <tomoki.sekiyama-7rDLJAbr9SE@public.gmane.org>,
"dle-develop-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<dle-develop-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH v3] efivars,efi-pstore: Hold off deletion of sysfs entry until, the scan is completed
Date: Wed, 30 Oct 2013 14:35:27 +0000 [thread overview]
Message-ID: <20131030143527.GB8193@console-pimps.org> (raw)
In-Reply-To: <A5ED84D3BB3A384992CBB9C77DEDA4D443F0F2D6-ohthHghroY0jroPwUH3sq+6wyyQG6/Uh@public.gmane.org>
On Fri, 18 Oct, at 10:30:58PM, Seiji Aguchi wrote:
> The scanning and deleting logic is still needed. In case an entry(A)
> is found, the pointer is saved to psi->data. And efi_pstore_read()
> passes the entry(A) to a pstore filesystem by releasing
> __efivars->lock.
>
> And then, the pstore filesystem calls efi_pstore_read() again and the
> same entry(A), which is saved to psi->data, is used for re-scanning a
> sysfs-list. (That is why list_for_each_entry_safe_from () is used in
> efi_pstore_sysfs_entry_iter().)
>
> So, to protect the entry(A), the logic is needed because, in pstore
> filesystem, __efivars->lock Is released.
Very good point.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-10-30 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 18:29 [PATCH v3] efivars,efi-pstore: Hold off deletion of sysfs entry until, the scan is completed Seiji Aguchi
[not found] ` <52584373.3010202-7rDLJAbr9SE@public.gmane.org>
2013-10-17 5:54 ` Madper Xie
[not found] ` <878uxssarf.fsf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-10-17 13:07 ` Seiji Aguchi
[not found] ` <A5ED84D3BB3A384992CBB9C77DEDA4D443F0BEB4-ohthHghroY0jroPwUH3sq+6wyyQG6/Uh@public.gmane.org>
2013-10-17 14:30 ` Madper Xie
[not found] ` <87fvs0as1p.fsf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-10-17 15:07 ` Madper Xie
2013-10-17 15:11 ` Seiji Aguchi
2013-10-17 13:18 ` Matt Fleming
[not found] ` <20131017131821.GH10834-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-18 22:30 ` Seiji Aguchi
[not found] ` <A5ED84D3BB3A384992CBB9C77DEDA4D443F0F2D6-ohthHghroY0jroPwUH3sq+6wyyQG6/Uh@public.gmane.org>
2013-10-30 14:35 ` Matt Fleming [this message]
[not found] ` <20131030143527.GB8193-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-30 19:19 ` Seiji Aguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030143527.GB8193@console-pimps.org \
--to=matt-hnk1s37rvnbexh+ff434mdi2o/jbrioy@public.gmane.org \
--cc=dle-develop-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=seiji.aguchi-7rDLJAbr9SE@public.gmane.org \
--cc=tomoki.sekiyama-7rDLJAbr9SE@public.gmane.org \
--cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox