From: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
Toshi Kani <toshi.kani-VXdhtT5mjnY@public.gmane.org>,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org,
horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org,
bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org,
ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [patch 1/3 v2] Add function get_bootparam
Date: Tue, 12 Nov 2013 00:30:12 -0800 [thread overview]
Message-ID: <20131112083012.GB7708@kroah.com> (raw)
In-Reply-To: <20131112080854.GD6999-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
On Tue, Nov 12, 2013 at 04:08:54PM +0800, Dave Young wrote:
> On 11/11/13 at 11:58pm, Greg KH wrote:
> > > kexec-tools can have a fallback to debugfs if we really need it, but
> > > making people mount debugfs to have some essential piece of
> > > functionality scares the heck out of me.
> >
> > I agree, that would not be good.
> >
> > I'm not sure what exactly the sysfs file is wanting to look like? The
> > efi section variable sysfs file isn't ok (multiple lines with multiple
> > values.) What is this going to look like?
>
> The current structure in debugfs is like below, export every field of setup
> header as one file will be too much IMHO:
> [root@darkstar debug]# tree boot_params
> boot_params
> ├── data /* binary data of setup header */
> ├── setup_data /* setup_data link list nodes */
> │ ├── 0
> │ │ ├── data /* binary data of setup data */
> │ │ └── type /* type of setup data */
> │ └── 1
> │ ├── data
> │ └── type
> └── version /* boot protocol version */
And these binary data blobs are a "standard" somewhere, and will not
change per kernel version change?
If so, that structure is fine with me.
thanks,
greg k-h
next prev parent reply other threads:[~2013-11-12 8:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 8:29 [patch 0/3 v2] kexec-tools: efi runtime support dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-05 8:29 ` [patch 1/3 v2] Add function get_bootparam dyoung-H+wXaHxf7aLQT0dZR+AlfA
[not found] ` <20131105083428.411624560-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-12 1:27 ` Toshi Kani
[not found] ` <1384219658.1847.84.camel-RbGIw1UOYPVo/CpIj0byZw@public.gmane.org>
2013-11-12 2:14 ` Dave Young
2013-11-12 3:20 ` H. Peter Anvin
[not found] ` <52819E71.70201-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-11-12 3:53 ` Ingo Molnar
[not found] ` <aa0ccca4-b27b-41b6-8adb-3c969eb29bf7@email.android.com>
[not found] ` <aa0ccca4-b27b-41b6-8adb-3c969eb29bf7-2ueSQiBKiTY7tOexoI0I+QC/G2K4zDHf@public.gmane.org>
2013-11-12 14:26 ` Vivek Goyal
2013-11-12 7:58 ` Greg KH
[not found] ` <20131112075831.GA6213-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-11-12 8:08 ` Dave Young
[not found] ` <20131112080854.GD6999-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-12 8:30 ` Greg KH [this message]
[not found] ` <20131112083012.GB7708-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-11-12 8:50 ` Dave Young
2013-11-12 9:37 ` H. Peter Anvin
[not found] ` <5281F6D5.4090700-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-11-12 9:51 ` Greg KH
[not found] ` <20131112095114.GA20100-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-11-13 0:50 ` Dave Young
[not found] ` <20131113005032.GB5069-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-18 2:22 ` Dave Young
[not found] ` <20131118022234.GD4025-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-18 3:29 ` H. Peter Anvin
[not found] ` <52898982.3020200-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-11-18 5:29 ` Dave Young
[not found] ` <20131118052949.GA14532-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-11-18 5:36 ` H. Peter Anvin
2013-11-05 8:29 ` [patch 2/3 v2] Add efi_info in x86 setup header dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-05 8:29 ` [patch 3/3 v2] Passing efi related data via setup_data dyoung-H+wXaHxf7aLQT0dZR+AlfA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112083012.GB7708@kroah.com \
--to=greg-u8xffu+wg4eavxtiumwx3w@public.gmane.org \
--cc=James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
--cc=toshi.kani-VXdhtT5mjnY@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox