From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Young Subject: Re: [patch 2/9 v3] efi: add a wrapper function efi_map_region_fixed Date: Fri, 22 Nov 2013 10:59:44 +0800 Message-ID: <20131122025944.GF3874@dhcp-16-126.nay.redhat.com> References: <20131121061704.363730447@dhcp-16-126.nay.redhat.com> <20131121061753.223578092@dhcp-16-126.nay.redhat.com> <20131121163947.GL26009@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20131121163947.GL26009-fF5Pk5pvG8Y@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Borislav Petkov Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org List-Id: linux-efi@vger.kernel.org > > } > > > > +/* > > + * kexec kernel will use efi_map_region_fixed to map efi > > + * runtime memory ranges. md->virt_addr is the original virtual > > + * address which had been mapped in kexec 1st kernel. > > + */ > > Why not stretch this comment to the full 80 cols? Since stretch them to 80 cols I still need 3 lines so I want the length to be more close to the length of context code lines, so It looks better to my eys :) I can change to 80 cols as you said below, thanks. > > /* > * kexec kernel will use efi_map_region_fixed to map efi runtime memory ranges. > * md->virt_addr is the original virtual address which had been mapped in kexec > * 1st kernel. > */ > -- Thanks for review Dave