From: Will Deacon <will.deacon@arm.com>
To: Mark Salter <msalter@redhat.com>
Cc: "matt.fleming@intel.com" <matt.fleming@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"patches@linaro.org" <patches@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
"roy.franz@linaro.org" <roy.franz@linaro.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] arm64: add EFI stub
Date: Tue, 3 Dec 2013 18:38:44 +0000 [thread overview]
Message-ID: <20131203183844.GA22668@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1385762712-17043-2-git-send-email-msalter@redhat.com>
Hi Mark, Roy,
On Fri, Nov 29, 2013 at 10:05:10PM +0000, Mark Salter wrote:
> This patch adds PE/COFF header fields to the start of the Image
> so that it appears as an EFI application to EFI firmware. An EFI
> stub is included to allow direct booting of the kernel Image. Due
> to EFI firmware limitations, only little endian kernels with 4K
> page sizes are supported at this time. Support in the COFF header
> for signed images was provided by Ard Biesheuvel.
I haven't really jumped into this but, whilst I see the use of EFI_STUB on
both arm and arm64, there seems to be some duplication/reinvention between
the two series you've put together.
Maybe I'm just being ignorant, but the stuff in efi-stub.c really looks to
be doing the same thing on both architectures. Would you guys be able to
work to together to produce an independent series containing the common
parts, then add arm/arm64 backends on top of that please? In particular,
factoring out the device-tree parts ensures that we don't introduce subtle
differences between the two architectures when there's no real need to do
so...
...or shout at me because I didn't understand what you were doing!
Cheers,
Will
next prev parent reply other threads:[~2013-12-03 18:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 22:05 [PATCH 0/3] arm64: Add EFI stub and runtime services support Mark Salter
[not found] ` < 1385762712-17043-2-git-send-email-msalter@redhat.com>
2013-11-29 22:05 ` [PATCH 1/3] arm64: add EFI stub Mark Salter
2013-12-03 18:38 ` Will Deacon [this message]
2013-12-03 19:31 ` Roy Franz
[not found] ` <20131203183844.GA22668-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2013-12-03 19:31 ` Mark Salter
2013-12-05 14:18 ` Catalin Marinas
[not found] ` <20131205141853.GA974-rtzwXk+D4rEjOxct69p1ducL+3YJyIBv@public.gmane.org>
2013-12-05 14:43 ` Mark Salter
[not found] ` <1386254603.1861.120.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2013-12-05 15:28 ` Catalin Marinas
[not found] ` < 20131205152806.GC974@darko.cambridge.arm.com>
[not found] ` <20131205152806.GC974-rtzwXk+D4rEjOxct69p1ducL+3YJyIBv@public.gmane.org>
2013-12-06 12:25 ` Grant Likely
2013-12-06 13:34 ` Mark Salter
2013-12-06 13:38 ` Leif Lindholm
2013-12-06 13:51 ` Mark Salter
2013-12-06 14:55 ` Mark Salter
2013-12-16 15:46 ` Catalin Marinas
2013-12-06 12:12 ` Grant Likely
[not found] ` <1385762712-17043-1-git-send-email-msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-11-29 22:05 ` [PATCH 2/3] doc: arm64: add description of EFI stub support Mark Salter
2013-11-29 22:05 ` [PATCH 3/3] arm64: add EFI runtime services Mark Salter
[not found] ` <1385762712-17043-4-git-send-email-msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-05 15:25 ` Catalin Marinas
[not found] ` <20131205152510.GB974-rtzwXk+D4rEjOxct69p1ducL+3YJyIBv@public.gmane.org>
2013-12-05 15:52 ` Mark Salter
[not found] ` <1386258761.1861.137.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2013-12-05 15:59 ` Catalin Marinas
2013-12-06 14:34 ` Mark Salter
2013-12-09 13:52 ` Leif Lindholm
[not found] ` <20131209135158.GH24997-GZEopFhza0F985/tl1ce8aaDwS/vmuI7@public.gmane.org>
2013-12-10 17:58 ` Mark Salter
[not found] ` < 1385762712-17043-3-git-send-email-msalter@redhat.com>
[not found] ` <1385762712-17043-3-git-send-email-msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-05 12:53 ` [PATCH 2/3] doc: arm64: add description of EFI stub support Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203183844.GA22668@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=msalter@redhat.com \
--cc=patches@linaro.org \
--cc=roy.franz@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).