* [PATCH -next] x86, efi: remove unused variable in __map_region()
@ 2013-12-06 12:59 Wei Yongjun
[not found] ` <CAPgLHd_Ain0ogMPtDNAk+sCbconT2QnA1mwFD6LR+jJKz=sN2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-12-06 12:59 UTC (permalink / raw)
To: matt.fleming-ral2JQCrhuEAvxtiuMwx3w, tglx-hfZtesqFncYOwBW4kG4KsQ,
mingo-H+wXaHxf7aLQT0dZR+AlfA, hpa-YMNOUZJC4hwAvxtiuMwx3w
Cc: yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
x86-DgEjT+Ai2ygdnm+yROfE0A, linux-efi-u79uwXL29TY76Z2rM5mHXA
From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
The variable end is initialized but never used
otherwise, so remove the unused variable.
Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
---
arch/x86/platform/efi/efi_64.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
index bf286c3..8ce7663 100644
--- a/arch/x86/platform/efi/efi_64.c
+++ b/arch/x86/platform/efi/efi_64.c
@@ -149,13 +149,11 @@ static void __init __map_region(efi_memory_desc_t *md, u64 va)
{
pgd_t *pgd = (pgd_t *)__va(real_mode_header->trampoline_pgd);
unsigned long pf = 0, size;
- u64 end;
if (!(md->attribute & EFI_MEMORY_WB))
pf |= _PAGE_PCD;
size = md->num_pages << PAGE_SHIFT;
- end = va + size;
if (kernel_map_pages_in_pgd(pgd, md->phys_addr, va, md->num_pages, pf))
pr_warn("Error mapping PA 0x%llx -> VA 0x%llx!\n",
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] x86, efi: remove unused variable in __map_region()
[not found] ` <CAPgLHd_Ain0ogMPtDNAk+sCbconT2QnA1mwFD6LR+jJKz=sN2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2013-12-11 10:53 ` Matt Fleming
0 siblings, 0 replies; 2+ messages in thread
From: Matt Fleming @ 2013-12-11 10:53 UTC (permalink / raw)
To: Wei Yongjun
Cc: matt.fleming-ral2JQCrhuEAvxtiuMwx3w, tglx-hfZtesqFncYOwBW4kG4KsQ,
mingo-H+wXaHxf7aLQT0dZR+AlfA, hpa-YMNOUZJC4hwAvxtiuMwx3w,
yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
x86-DgEjT+Ai2ygdnm+yROfE0A, linux-efi-u79uwXL29TY76Z2rM5mHXA,
Dave Young
On Fri, 06 Dec, at 08:59:49PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
>
> The variable end is initialized but never used
> otherwise, so remove the unused variable.
>
> Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
> ---
> arch/x86/platform/efi/efi_64.c | 2 --
> 1 file changed, 2 deletions(-)
Thanks, but Dave Young has already sent a patch for this.
--
Matt Fleming, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-11 10:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-06 12:59 [PATCH -next] x86, efi: remove unused variable in __map_region() Wei Yongjun
[not found] ` <CAPgLHd_Ain0ogMPtDNAk+sCbconT2QnA1mwFD6LR+jJKz=sN2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-11 10:53 ` Matt Fleming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).