From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Young Subject: Re: [PATCH v5 02/14] efi: use early_memremap and early_memunmap Date: Thu, 12 Dec 2013 10:04:26 +0800 Message-ID: <20131212020426.GA3751@dhcp-16-126.nay.redhat.com> References: <1386582147-9802-1-git-send-email-dyoung@redhat.com> <1386582147-9802-3-git-send-email-dyoung@redhat.com> <20131211103903.GC19196@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20131211103903.GC19196-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Matt Fleming Cc: mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, Mark Salter , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Leif Lindholm , James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: linux-efi@vger.kernel.org On 12/11/13 at 10:39am, Matt Fleming wrote: > (Cc'ing Leif and Mark for the ARM-side of things) > > On Mon, 09 Dec, at 05:42:15PM, Dave Young wrote: > > In arch/x86/platform/efi/efi.c and drivers/firmware/efi/efi.c turn to use > > early_memremap/early_memunmap instead of early_ioremap/early_iounmap so sparse > > will be happy. > > > > Signed-off-by: Dave Young > > --- > > arch/x86/platform/efi/efi.c | 20 ++++++++++---------- > > drivers/firmware/efi/efi.c | 4 ++-- > > 2 files changed, 12 insertions(+), 12 deletions(-) > > This looks like a rather nice cleanup but the commit log could use a > little bit of tweaking... > > - Please start your commit title (the part after the subsystem tag) > with a capital letter, e.g. > > efi: Use early_memremap... > > - You need to explain in the commit title that you're fixing a sparse > warning. Anyone reading the patch subject will have no idea _why_ > you're using early_memremap() and early_memunmap(). > > - In the commit message body explain why sparse is currently unhappy. Sure, will do. -- Thanks for review Dave