From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data Date: Thu, 12 Dec 2013 22:04:39 +0100 Message-ID: <20131212210439.GB30162@pd.tnic> References: <1386582147-9802-1-git-send-email-dyoung@redhat.com> <1386582147-9802-10-git-send-email-dyoung@redhat.com> <20131211222057.GB8863@pd.tnic> <20131212030619.GG3751@dhcp-16-126.nay.redhat.com> <20131212071743.GJ3751@dhcp-16-126.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20131212071743.GJ3751-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Young Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org List-Id: linux-efi@vger.kernel.org On Thu, Dec 12, 2013 at 03:17:43PM +0800, Dave Young wrote: > Rethink about this issue, moving them to efi_$(BITS).c I need move the > efi_setup from a static variable to an extern, It looks not worth. Dave, would you please do what is suggested to you? A big part of the efi code is split into 32-bit and 64-bit functionality. If you have a serious argument why it shouldn't be done so then sure, by all means, but stop coming up with silly arguments like having an extern declaration is a bad thing. Please. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --