From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Young Subject: Re: [PATCH v5 10/14] efi: only print saved efi runtime maps instead of all memmap ranges for kexec Date: Wed, 18 Dec 2013 10:06:27 +0800 Message-ID: <20131218020627.GA3917@dhcp-16-126.nay.redhat.com> References: <1386582147-9802-1-git-send-email-dyoung@redhat.com> <1386582147-9802-11-git-send-email-dyoung@redhat.com> <20131213160150.GE32329@pd.tnic> <20131216020010.GC3754@dhcp-16-126.nay.redhat.com> <20131216113324.GB4922@pd.tnic> <20131217063436.GF6751@dhcp-16-126.nay.redhat.com> <20131217155844.GG30592@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20131217155844.GG30592-fF5Pk5pvG8Y@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Borislav Petkov Cc: mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org, matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: linux-efi@vger.kernel.org On 12/17/13 at 04:58pm, Borislav Petkov wrote: > On Tue, Dec 17, 2013 at 02:34:36PM +0800, Dave Young wrote: > > They are moved to efi.c efi_setup_init(), I'm not sure if I expained > > clear enough, in current code parse_efi_setup only accept one argument > > phys_addr so I will mapping it with sizeof(struct setup_data) to > > get the payload size then get the nr_efi_runtime_map. This is a > > simplification from the old implementation. > > > > Based on current implementation, yes, I can add back another argument > > data_len to avoid the 1st mapping thus I can print efi memmap as you > > said. > > > > In this way I need export another extern for the data_len though. > > Well, think about it: do you want to do the memremap/unmap a second time > *just* to print the memmap in the efi kernel or do you want to do the > memremap/unmap only once and do the work once? > > If you say you don't care about speed and wasting cycles then I'm > certainly fine with that as I've spent more time hinting at the > performance aspect than I'd like to. For these non critical path I would prefer the code which should be easier to be understood. But yes I have managed to work out what you want in latest version. Of course I appreciate your time for reviewing those patches. Thanks. > > > What do you mean about NOPARSE, do you want another function name like > > save_efi_setup()? > > -ENOPARSE means I cannot parse what you said above. Ok. Thanks Dave