From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Young Subject: Re: [PATCH v7 00/12] kexec kernel efi runtime support Date: Fri, 3 Jan 2014 12:12:37 +0800 Message-ID: <20140103041237.GA4506@dhcp-16-198.nay.redhat.com> References: <1387533742-18018-1-git-send-email-dyoung@redhat.com> <20131221173515.GE29501@console-pimps.org> <20140102024256.GB2563@darkstar.nay.redhat.com> <20140102103549.GC2618@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20140102103549.GC2618-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Matt Fleming Cc: mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: linux-efi@vger.kernel.org > Please send these as separate patches and include the compiler errors in > the commit message. I'll pick them up and send them to Peter. Sent. > > > build fix: move parse_efi_setup to efi*.c, call it in efi_init instead in setup.c > > Why have you moved the call site for parse_efi_setup()? What's the > rationale? Parsing SETUP_* entries outside of parse_setup_data() seems > to me to be a step backwards in terms of clarity. SETUP_PCI also duplicate the parsing logic out of setup.c. I added static inline in ifdef else branch, but I got some warnings yestoday about "unused function", double checked it today there's no such warnings anymore, it might be caused by some mistake. Changed to static inline {} in patches I just sent a moment ago. Thanks Dave