From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [RFT][PATCH] ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode() (was: Re: [RFC PATCH 00/14] Support timezone of ACPI TAD and EFI TIME) Date: Sun, 12 Jan 2014 11:05:46 +0000 Message-ID: <20140112110546.GB25180@console-pimps.org> References: <1387439053-8711-1-git-send-email-jlee@suse.com> <3476450.BMEcId2Lgj@vostro.rjw.lan> <20131221122148.GB29501@console-pimps.org> <2530951.HFPX8MI38t@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2530951.HFPX8MI38t-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Rafael J. Wysocki" Cc: "H. Peter Anvin" , joeyli , Alessandro Zummo , Matthew Garrett , Elliott-VXdhtT5mjnY@public.gmane.org, samer.el-haj-mahmoud-VXdhtT5mjnY@public.gmane.org, Oliver Neukum , werner-IBi9RG/b67k@public.gmane.org, trenn-l3A5Bk7waGM@public.gmane.org, JBeulich-IBi9RG/b67k@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Borislav Petkov List-Id: linux-efi@vger.kernel.org On Sun, 12 Jan, at 01:30:23AM, Rafael J. Wysocki wrote: > On Saturday, December 21, 2013 12:21:48 PM Matt Fleming wrote: > > On Fri, 20 Dec, at 11:18:56PM, Rafael J. Wysocki wrote: > > > > > > I'm not sure 100%, but I *think* we need to do that with interrupts enabled. > > > At least after mm_init(), because it relies on things initialized there if I > > > remember correctly. > > > > > > From what I can tell at the moment, it might be possible to move it before > > > efi_enter_virtual_mode() if that would help. > > > > Actually yeah, that would be super useful, and I think we'd be able to > > get rid of the whole efi_late_init() stuff because we'd no longer need > > to hang on to the EFI_BOOT_SERVICES* regions after > > SetVirtualAddressMap(). > > OK > > I don't see any adverse effects of the patch below on a couple of my test > boxes, but (a) they are Intel-based and (b) they are non-EFI, so it would be > good to give it a go on as many machines as reasonably possible. Thanks Rafael, I'll give this a spin on my test machines here. -- Matt Fleming, Intel Open Source Technology Center