From: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
To: Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH] efi: x86: make "efi facility" use slightly more generic
Date: Wed, 15 Jan 2014 14:22:08 +0000 [thread overview]
Message-ID: <20140115142208.GA18749@console-pimps.org> (raw)
In-Reply-To: <1389721285-32390-1-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Tue, 14 Jan, at 05:41:25PM, Leif Lindholm wrote:
> Currently, efi_enabled() is defined to be a dummy macro always returning
> 1 unless CONFIG_X86. Change this logic to use a
> CONFIG_ARCH_USES_EFI_FACILITY to enable use by other architectures.
>
> Signed-off-by: Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> arch/x86/Kconfig | 1 +
> drivers/firmware/efi/Kconfig | 3 +++
> include/linux/efi.h | 2 +-
> 3 files changed, 5 insertions(+), 1 deletion(-)
I'm not sure this is the way to go. I'd much prefer to treat introducing
CONFIG_* symbols like this a last resort only.
Let me post some patches to show you what I had in mind.
--
Matt Fleming, Intel Open Source Technology Center
prev parent reply other threads:[~2014-01-15 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 17:41 [PATCH] efi: x86: make "efi facility" use slightly more generic Leif Lindholm
[not found] ` <1389721285-32390-1-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-01-15 14:22 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115142208.GA18749@console-pimps.org \
--to=matt-hnk1s37rvnbexh+ff434mdi2o/jbrioy@public.gmane.org \
--cc=leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).