Re: [RFC][PATCH 01/11] x86/boot: Cleanup header.S by removing some #ifdefs

[Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>]

On Wed, Jan 29, 2014 at 04:23:47PM +0000, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> handover_offset is now filled out by build.c. Don't set a default value
> as it will be overwritten anyway.
> 
> Signed-off-by: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Acked-by: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>

> ---
>  arch/x86/boot/header.S | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index ec3b8ba68096..d69d96653325 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -426,13 +426,7 @@ pref_address:		.quad LOAD_PHYSICAL_ADDR	# preferred load addr
>  #define INIT_SIZE VO_INIT_SIZE
>  #endif
>  init_size:		.long INIT_SIZE		# kernel initialization size
> -handover_offset:
> -#ifdef CONFIG_EFI_STUB
> -  			.long 0x30		# offset to the handover
> -						# protocol entry point
> -#else
> -			.long 0
> -#endif
> +handover_offset:	.long 0			# Filled in by build.c

That's efi_stub_entry in there, right?

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--