From: Will Deacon <will.deacon@arm.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "roy.franz@linaro.org" <roy.franz@linaro.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"patches@linaro.org" <patches@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"matt.fleming@intel.com" <matt.fleming@intel.com>,
"msalter@redhat.com" <msalter@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 2/5] arm: add new asm macro update_sctlr
Date: Mon, 3 Feb 2014 10:34:15 +0000 [thread overview]
Message-ID: <20140203103415.GA12187@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20140130131247.GG11329@bivouac.eciton.net>
On Thu, Jan 30, 2014 at 01:12:47PM +0000, Leif Lindholm wrote:
> Oh, that's neat - thanks!
>
> Well, given that, I can think of two less horrible options:
> 1)
> .macro update_sctlr, tmp:req, set=, clear=
> mrc p15, 0, \tmp, c1, c0, 0
> .ifnc \set,
> orr \tmp, \set
> .endif
> .ifnc \clear,
> mvn \clear, \clear
> and \tmp, \tmp, \clear
Can't you use bic here?
> .endif
> mcr p15, 0, \tmp, c1, c0, 0
> .endm
>
> With the two call sites in uefi_phys.S as:
>
> ldr r5, =(CR_M)
> update_sctlr r12, , r5
> and
> ldr r4, =(CR_I | CR_C | CR_M)
> update_sctlr r12, r4
These ldr= could be movs, right?
If so, I definitely prefer this to putting an ldr = into the macro itself
(option 2).
Cheers,
Will
next prev parent reply other threads:[~2014-02-03 10:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 13:05 [PATCH v4 0/5] arm: add UEFI runtime services support Leif Lindholm
2014-01-11 13:05 ` [PATCH v4 1/5] arm: break part of __soft_restart out into separate function Leif Lindholm
[not found] ` <1389445524-30623-2-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-01-22 11:09 ` Will Deacon
[not found] ` <1389445524-30623-1-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-01-11 13:05 ` [PATCH v4 2/5] arm: add new asm macro update_sctlr Leif Lindholm
[not found] ` <1389445524-30623-3-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-01-22 11:20 ` Will Deacon
[not found] ` <20140122112055.GF1621-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2014-01-29 18:28 ` Leif Lindholm
2014-01-29 19:27 ` Will Deacon
2014-01-29 20:58 ` Mark Salter
[not found] ` <1391029124.2488.50.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-01-30 13:12 ` Leif Lindholm
2014-02-03 10:34 ` Will Deacon [this message]
[not found] ` <20140203103415.GA12187-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2014-02-03 15:55 ` Leif Lindholm
2014-02-03 16:00 ` Will Deacon
2014-02-03 16:20 ` Rob Herring
2014-02-03 16:46 ` Leif Lindholm
2014-02-03 16:57 ` Will Deacon
[not found] ` <20140203165718.GO14112-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org>
2014-02-03 18:15 ` Leif Lindholm
2014-01-11 13:05 ` [PATCH v4 3/5] Documentation: arm: add UEFI support documentation Leif Lindholm
2014-01-11 13:05 ` [PATCH v4 4/5] arm: Add [U]EFI runtime services support Leif Lindholm
[not found] ` <1389445524-30623-5-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-01-13 15:40 ` Matt Fleming
2014-01-13 18:43 ` Arnd Bergmann
2014-01-13 20:01 ` Leif Lindholm
[not found] ` <20140113200135.GF30907-t77nlHhSwNqAroYi2ySoxKxOck334EZe@public.gmane.org>
2014-01-14 6:52 ` Arnd Bergmann
[not found] ` <201401140752.33257.arnd-r2nGTMty4D4@public.gmane.org>
2014-01-14 11:44 ` Leif Lindholm
[not found] ` <20140114114419.GH30907-t77nlHhSwNqAroYi2ySoxKxOck334EZe@public.gmane.org>
2014-01-14 13:26 ` Arnd Bergmann
[not found] ` <201401141426.16497.arnd-r2nGTMty4D4@public.gmane.org>
2014-01-14 15:25 ` Leif Lindholm
2014-01-11 13:05 ` [PATCH v4 5/5] init: efi: arm: enable (U)EFI runtime services on arm Leif Lindholm
2014-01-13 18:29 ` Arnd Bergmann
[not found] ` <201401131929.07236.arnd-r2nGTMty4D4@public.gmane.org>
2014-01-13 18:57 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140203103415.GA12187@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=grant.likely@secretlab.ca \
--cc=leif.lindholm@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matt.fleming@intel.com \
--cc=msalter@redhat.com \
--cc=patches@linaro.org \
--cc=roy.franz@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).