From: Matt Fleming <matt@console-pimps.org>
To: David Rientjes <rientjes@google.com>
Cc: linux-efi@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Borislav Petkov <bp@alien8.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Matthew Garrett <mjg59@srcf.ucam.org>,
linux-kernel@vger.kernel.org,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH v2 00/13] EFI mixed mode
Date: Thu, 6 Mar 2014 21:40:14 +0000 [thread overview]
Message-ID: <20140306214014.GA8942@console-pimps.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1403061325250.25499@chino.kir.corp.google.com>
On Thu, 06 Mar, at 01:27:23PM, David Rientjes wrote:
>
> This was merged into tip#x86/efi-mixed and results in a build error,
> config attached:
>
> arch/x86/boot/tools/build.c: In function 'update_pecoff_setup_and_reloc':
> arch/x86/boot/tools/build.c:259:1: error: parameter name omitted
> arch/x86/boot/tools/build.c: In function 'update_pecoff_text':
> arch/x86/boot/tools/build.c:260:1: error: parameter name omitted
> arch/x86/boot/tools/build.c:260:1: error: parameter name omitted
> arch/x86/boot/tools/build.c: In function 'main':
> arch/x86/boot/tools/build.c:380:2: warning: implicit declaration of function 'efi_stub_entry_update' [-Wimplicit-function-declaration]
> arch/x86/boot/compressed/head_64.o: In function `efi64_config':
> (.data+0x90): undefined reference to `efi_call6'
Thanks for the report David.
I sent a pull request that fixes these errors up. Looks like it got
pulled into tip:x86/efi,
commit 617b3c37da78
Merge: 994448f1afa6 3db4cafdfd05
Author: Matt Fleming <matt.fleming@intel.com>
Date: Wed Mar 5 18:18:50 2014 +0000
Merge branch 'mixed-mode' into efi-for-mingo
So everything should be working in tip:x86/efi which includes
tip:x86/efi-mixed.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-03-06 21:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 13:14 [PATCH v2 00/13] EFI mixed mode Matt Fleming
2014-03-04 13:14 ` [PATCH 01/13] x86/boot: Cleanup header.S by removing some #ifdefs Matt Fleming
2014-03-04 13:14 ` [PATCH 02/13] x86, tools: Consolidate #ifdef code Matt Fleming
2014-03-04 13:14 ` [PATCH 03/13] x86/mm/pageattr: Always dump the right page table in an oops Matt Fleming
2014-03-04 13:14 ` [PATCH 04/13] x86/efi: Delete dead code when checking for non-native Matt Fleming
2014-03-04 13:14 ` [PATCH 05/13] efi: Add separate 32-bit/64-bit definitions Matt Fleming
2014-03-04 13:14 ` [PATCH 08/13] x86/efi: Split the boot stub into 32/64 code paths Matt Fleming
2014-03-04 13:14 ` [PATCH 09/13] x86/efi: Firmware agnostic handover entry points Matt Fleming
2014-03-04 13:14 ` [PATCH 10/13] x86/efi: Add mixed runtime services support Matt Fleming
2014-03-04 13:14 ` [PATCH 11/13] x86/efi: Wire up CONFIG_EFI_MIXED Matt Fleming
2014-03-04 13:14 ` [PATCH 12/13] x86/boot: Don't overwrite cr4 when enabling PAE Matt Fleming
2014-03-04 13:14 ` [PATCH 13/13] x86/efi: Re-disable interrupts after calling firmware services Matt Fleming
[not found] ` <1393938861-16797-1-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-03-04 13:14 ` [PATCH v2 06/13] x86/efi: Build our own EFI services pointer table Matt Fleming
[not found] ` <1393938861-16797-7-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-03-22 0:52 ` Roy Franz
[not found] ` <CAFECyb8QKy-r_2a7Dy8j9Nv=8pGUKJbnOzLoJhd6shvf0PmBCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-22 11:05 ` Matt Fleming
[not found] ` <20140322110515.GF2815-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-03-22 20:16 ` Roy Franz
[not found] ` <CAFECyb8VnNzwUEOY-jkO60_9yKw_sbp_K5UQZU5EECcNjAs+sg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-25 22:47 ` Roy Franz
[not found] ` <CAFECyb-+uBtmPQZzsJBugROo-AjAwXEvX48-1pPKwiSJwfWGUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-26 9:10 ` Matt Fleming
2014-03-25 22:40 ` [PATCH] Add efi_early_call() macro Roy Franz
[not found] ` <1395787231-14298-1-git-send-email-roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-03-26 8:59 ` Matt Fleming
2014-03-26 17:40 ` Roy Franz
2014-03-04 13:14 ` [PATCH 07/13] x86/efi: Add early thunk code to go from 64-bit to 32-bit Matt Fleming
2014-03-06 21:27 ` [PATCH v2 00/13] EFI mixed mode David Rientjes
2014-03-06 21:40 ` Matt Fleming [this message]
[not found] ` <20140306214014.GA8942-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-03-07 10:11 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306214014.GA8942@console-pimps.org \
--to=matt@console-pimps.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mjg59@srcf.ucam.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).