From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Matt Fleming <matt@console-pimps.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Ingo Molnar <mingo@kernel.org>,
Matt Fleming <matt.fleming@intel.com>,
Nathan Zimmer <nzimmer@sgi.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-efi@vger.kernel.org,
kernel-janitors@vger.kernel.org, Jan Beulich <JBeulich@suse.com>
Subject: Re: [patch] x86/efi: use GFP_ATOMIC under spin_lock
Date: Sun, 9 Mar 2014 19:00:53 +0000 [thread overview]
Message-ID: <20140309190053.GA29555@srcf.ucam.org> (raw)
In-Reply-To: <20140309185028.GB10262@console-pimps.org>
On Sun, Mar 09, 2014 at 06:50:28PM +0000, Matt Fleming wrote:
> Is there any value in that? Do machines exist where we absolutely must
> have access to the EFI time services? Either because there's no other
> method or no other working one?
In theory we get timezones, which we otherwise only get if we have an
ACPI TAD device.
> I can check again, but I'm pretty sure this ASUS machine under my desk
> always returns a vendor-specific error code when invoked, even with
> Borislav's 1:1 patches. Enabling EFI services just because they exist
> hasn't worked out well for us in the past.
Returning an error doesn't seem like a problem, as long as it's not
actually killing the machine in the process...
> And of course, the GPF_KERNEL alloc under spinlock bug that started this
> thread needs to be fixed.
Losing phys_efi_get_time() doesn't seem like it ought to be much of a
problem.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2014-03-09 19:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 11:20 [patch] x86/efi: use GFP_ATOMIC under spin_lock Dan Carpenter
[not found] ` <20140307112055.GE2351-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2014-03-07 12:10 ` Ingo Molnar
[not found] ` <20140307121022.GA32575-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-07 12:25 ` Dan Carpenter
2014-03-09 6:48 ` Ingo Molnar
2014-03-09 7:14 ` Dan Carpenter
2014-03-09 16:20 ` Matt Fleming
2014-03-09 16:31 ` Matthew Garrett
[not found] ` <20140309163141.GA18824-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2014-03-09 18:50 ` Matt Fleming
2014-03-09 19:00 ` Matthew Garrett [this message]
[not found] ` <20140309190053.GA29555-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2014-03-10 9:10 ` Matt Fleming
[not found] ` <20140309185028.GB10262-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-03-10 7:27 ` Jan Beulich
2014-03-10 7:37 ` Ingo Molnar
2014-03-10 7:45 ` Jan Beulich
2014-03-10 7:53 ` Ingo Molnar
2014-03-10 8:22 ` Jan Beulich
2014-03-10 10:43 ` Matt Fleming
[not found] ` <20140310104328.GG10262-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-03-10 11:05 ` Jan Beulich
[not found] ` <531DAA7602000078001224EF-ce6RLXgGx+vWGUEhTRrCg1aTQe2KTcn/@public.gmane.org>
2014-03-10 16:10 ` Matt Fleming
2014-03-14 23:02 ` Matt Fleming
2014-03-10 9:12 ` Matt Fleming
2014-03-10 7:26 ` Jan Beulich
2014-03-10 17:07 ` Dan Carpenter
2014-03-09 7:36 ` Dan Carpenter
2014-03-10 16:47 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140309190053.GA29555@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=JBeulich@suse.com \
--cc=dan.carpenter@oracle.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=nzimmer@sgi.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).