From: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
Cc: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [GIT PULL] EFI urgent fixes
Date: Fri, 11 Apr 2014 10:27:16 +0200 [thread overview]
Message-ID: <20140411082716.GC15418@gmail.com> (raw)
In-Reply-To: <20140411071622.GB17021-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
* Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> wrote:
> Guys, please pull the following. One of the fixes is for a regression
> introduced during the merge window. The other two are bugs that have
> existed in the EFI boot stub for a while, but which have only just been
> reported.
>
> I'm going to take care of submitting the later two to stable separately
> because they won't apply cleanly as-is.
>
> The following changes since commit 204b0a1a4b92612c957a042df1a3be0e9cc79391:
>
> x86, efi: Abstract x86 efi_early calls (2014-03-26 11:30:03 -0700)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git tags/efi-urgent
>
> for you to fetch changes up to 47514c996fac5e6f13ef3a4c5e23f1c5cffabb7b:
>
> efi: Pass correct file handle to efi_file_{read,close} (2014-04-10 21:20:03 +0100)
>
> ----------------------------------------------------------------
> * Fix EFI boot regression introduced during the merge window where the
> firmware was reading random values from the stack because we were
> passing a pointer to the wrong object type.
>
> * Kernel corruption has been reported when booting with the EFI boot
> stub which was tracked down to setting a bogus value for
> bp->hdr.code32_start, resulting in corruption during relocation.
>
> * Olivier Martin reported that the wrong file handles were being passed
> to efi_file_(read|close), which works for x86 by luck due to the way
> that the FAT driver is implemented, but doesn't work on ARM.
>
> ----------------------------------------------------------------
> Matt Fleming (3):
> x86/efi: Fix boot failure with EFI stub
> x86/efi: Correct EFI boot stub use of code32_start
> efi: Pass correct file handle to efi_file_{read,close}
>
> arch/x86/boot/compressed/eboot.c | 19 ++++++++++---------
> arch/x86/boot/compressed/head_32.S | 8 ++------
> arch/x86/boot/compressed/head_64.S | 9 +++------
> drivers/firmware/efi/efi-stub-helper.c | 6 +++---
> 4 files changed, 18 insertions(+), 24 deletions(-)
Pulled, thanks a lot Matt!
Ingo
next prev parent reply other threads:[~2014-04-11 8:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 7:16 [GIT PULL] EFI urgent fixes Matt Fleming
[not found] ` <20140411071622.GB17021-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-04-11 8:27 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-30 21:06 Matt Fleming
[not found] ` <20150730210643.GM2725-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-07-31 7:56 ` Ingo Molnar
2015-05-05 16:27 Matt Fleming
[not found] ` <20150505162755.GA3767-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-05-06 6:31 ` Ingo Molnar
2015-03-02 12:51 Matt Fleming
[not found] ` <20150302125104.GC24476-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-03-02 13:24 ` Ingo Molnar
2015-03-02 13:35 ` Matt Fleming
2015-02-18 11:55 Matt Fleming
[not found] ` <20150218115543.GA5648-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-02-18 13:43 ` Ingo Molnar
[not found] ` <20150218134357.GA386-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-18 16:36 ` Ard Biesheuvel
[not found] ` <D0B4679E-92EB-4A22-8D3E-9D0C27A09ACD-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-02-18 16:57 ` Ingo Molnar
2014-09-25 7:31 Matt Fleming
[not found] ` <20140925073133.GQ18635-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-25 14:41 ` Ingo Molnar
[not found] ` <20140925144127.GA3828-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-25 14:44 ` Matt Fleming
2014-09-26 11:27 ` Paul Bolle
2014-09-26 11:35 ` Ingo Molnar
[not found] ` <20140926113510.GA14625-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-26 12:24 ` Matt Fleming
[not found] ` <20140926122405.GW18635-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-27 5:49 ` Ingo Molnar
2014-09-26 11:44 ` Matt Fleming
[not found] ` <20140926114454.GV18635-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-26 11:59 ` Paul Bolle
2014-09-26 12:34 ` Matt Fleming
2014-09-26 12:55 ` Paul Bolle
[not found] ` <20140926123429.GX18635-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-27 8:04 ` Valentin Rothberg
[not found] ` <CAD3Xx4JmkDZ1Cw02DFAE0fa0EaEmBi8-W-p7JCfEXLERK5yuUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-27 9:59 ` Paul Bolle
2014-09-08 21:55 Matt Fleming
[not found] ` <20140908215535.GD18582-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-09 5:07 ` Ingo Molnar
[not found] ` <20140909050749.GB6770-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-09 7:07 ` Matt Fleming
2014-09-09 14:55 ` Ingo Molnar
2014-08-22 7:52 Matt Fleming
[not found] ` <20140822075221.GK29733-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-08-22 8:15 ` Ingo Molnar
2014-07-14 12:54 Matt Fleming
2014-06-27 14:51 Matt Fleming
2014-06-04 16:53 Matt Fleming
2014-02-14 13:08 Matt Fleming
2013-11-29 12:09 Matt Fleming
2013-07-11 11:16 Matt Fleming
2013-06-07 11:50 Matt Fleming
[not found] ` <20130607115046.GN30420-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-06-10 21:36 ` Matt Fleming
2013-05-17 10:18 Matt Fleming
2013-04-25 8:49 Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411082716.GC15418@gmail.com \
--to=mingo-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).