From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: [PATCH]x86 efi: do not export efi runtime map in case old map Date: Fri, 30 May 2014 08:59:00 -0400 Message-ID: <20140530125900.GB16605@redhat.com> References: <20140530032010.GA29906@dhcp-16-198.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140530032010.GA29906-je1gSBvt1Tc/CGXRbJeUwh/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Young Cc: matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-efi@vger.kernel.org On Fri, May 30, 2014 at 11:20:10AM +0800, Dave Young wrote: > > For ioremapped efi memory aka old_map the virt addresses are not persistant > across kexec reboot. kexec-tools will read the runtime maps from sysfs then > pass them to 2nd kernel and assuming kexec efi boot is ok. This will cause > kexec boot failure. > > To address this issue do not export runtime maps in case efi old_map so > userspace can use no efi boot instead. > > Signed-off-by: Dave Young Looks good to me. Acked-by: Vivek Goyal Vivek > --- > arch/x86/platform/efi/efi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c > index 3781dd3..4d36932 100644 > --- a/arch/x86/platform/efi/efi.c > +++ b/arch/x86/platform/efi/efi.c > @@ -919,6 +919,9 @@ static void __init save_runtime_map(void) > void *tmp, *p, *q = NULL; > int count = 0; > > + if (efi_enabled(EFI_OLD_MEMMAP)) > + return; > + > for (p = memmap.map; p < memmap.map_end; p += memmap.desc_size) { > md = p; > > -- > 1.8.3.1