From: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>
To: Alex Thorlton <athorlton-sJ/iWh9BUns@public.gmane.org>
Cc: Linux EFI <linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Matt Fleming
<matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>,
Russ Anderson <rja-sJ/iWh9BUns@public.gmane.org>
Subject: efi_call on SGI
Date: Tue, 10 Jun 2014 22:44:14 +0200 [thread overview]
Message-ID: <20140610204414.GB29302@pd.tnic> (raw)
In-Reply-To: <20140610080300.GA28607-fF5Pk5pvG8Y@public.gmane.org>
Btw,
while we're at it, I see uv_bios_call is sometimes done with preemption
disabled around it and sometimes it is not (at least I don't see it)...
In any case, if SGI uses the EFI pagetable now too, you probably would
want to do the efi calls like the rest of x86 does them - see the 64-bit
version of efi_call_virt() in arch/x86/include/asm/efi.h for an example
what I mean.
Now, you could either copy that macro or you could accomodate it to
serve everyone's needs - depends on what you'd prefer.
I'm just saying - I had stumbled across this while the debugging session
was going on and wanted to point that out but it wasn't too important at
the time so...
HTH.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-06-10 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 20:00 [RFC] Best place/method to determine BIOS version? Alex Thorlton
[not found] ` <20140609200017.GD2700-sJ/iWh9BUns@public.gmane.org>
2014-06-10 8:03 ` Borislav Petkov
[not found] ` <20140610080300.GA28607-fF5Pk5pvG8Y@public.gmane.org>
2014-06-10 20:44 ` Borislav Petkov [this message]
[not found] ` <20140610204414.GB29302-fF5Pk5pvG8Y@public.gmane.org>
2014-06-11 17:32 ` efi_call on SGI Alex Thorlton
2014-06-11 8:55 ` [RFC] Best place/method to determine BIOS version? Matt Fleming
2014-06-11 17:30 ` Alex Thorlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610204414.GB29302@pd.tnic \
--to=bp-l3a5bk7wagm@public.gmane.org \
--cc=athorlton-sJ/iWh9BUns@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
--cc=rja-sJ/iWh9BUns@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox