From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH] efi: fix pointer type errors in fdt_uefi_find_params() Date: Wed, 18 Jun 2014 10:02:45 +0100 Message-ID: <20140618090245.GC24049@console-pimps.org> References: <1402671299-22493-1-git-send-email-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1402671299-22493-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: linux-efi@vger.kernel.org On Fri, 13 Jun, at 04:54:59PM, Ard Biesheuvel wrote: > Fix two instances of pointer type errors, a harmless one where a const void* > value is assigned to a non-const void* variable, and a not-so-harmless one where > we pass a pointer to unsigned long where a pointer to int is expected. > > Signed-off-by: Ard Biesheuvel > --- > drivers/firmware/efi/efi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > index cd36deb619fa..fe737832a882 100644 > --- a/drivers/firmware/efi/efi.c > +++ b/drivers/firmware/efi/efi.c > @@ -353,8 +353,8 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname, > int depth, void *data) > { > struct param_info *info = data; > - void *prop, *dest; > - unsigned long len; > + void const *prop, *dest; > + int len; > u64 val; > int i; const void *? -- Matt Fleming, Intel Open Source Technology Center