Re: [PATCH] efi/arm64: efistub: remove local copy of linux_banner

Matt Fleming
2014-06-18T09:25:02Z

On Wed, 18 Jun, at 11:12:28AM, Ard Biesheuvel wrote:
>
> This just removes the duplicate definition of linux_banner, *not* the
> reference to it a couple of lines down. IOW, the DT bindings and
> everything behind it are not affected at all by this patch.
> The reason it works fine for arm64 is that its stub is part of the
> kernel proper, so the reference will bind to the global definition
> instead.

Aha, thanks.

> What will be affected is 32-bit ARM, as its stub is not part of the
> kernel proper. In this case, we will propose an alternative [and
> better] way of allowing the stub to reference linux_banner, i.e.,
> without having to redefine it at the C level. We will take this into
> account when we propose the next round of efistub patches for ARM.

No complaints from me.