From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v5 0/7] xen: Add EFI support Date: Wed, 18 Jun 2014 10:31:43 -0400 Message-ID: <20140618143143.GB8545@laptop.dumpdata.com> References: <1402678823-24589-1-git-send-email-daniel.kiper@oracle.com> <20140618141541.GM24049@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140618141541.GM24049-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Fleming Cc: Daniel Kiper , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, andrew.cooper3-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, eshelton-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, jbeulich-IBi9RG/b67k@public.gmane.org, jeremy-TSDbQ3PG+2Y@public.gmane.org, matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org List-Id: linux-efi@vger.kernel.org On Wed, Jun 18, 2014 at 03:15:41PM +0100, Matt Fleming wrote: > On Fri, 13 Jun, at 07:00:16PM, Daniel Kiper wrote: > > Hey, > > > > This patch series adds EFI support for Xen dom0 guests. > > It is based on Jan Beulich and Tang Liang work. I was > > trying to take into account all previous comments, > > however, if I missed something sorry for that. > > > > Daniel > > > > arch/x86/kernel/setup.c | 4 +- > > arch/x86/platform/efi/efi.c | 77 ++++++++++------- > > arch/x86/xen/enlighten.c | 24 ++++++ > > drivers/firmware/efi/efi.c | 26 +++--- > > drivers/xen/Kconfig | 4 + > > drivers/xen/Makefile | 3 + > > drivers/xen/efi.c | 374 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > include/linux/efi.h | 3 +- > > include/xen/interface/platform.h | 123 +++++++++++++++++++++++++++ > > 9 files changed, 595 insertions(+), 43 deletions(-) > > FWIW I'm much happier with this version than v4. There's nothing that > jumps out at me as being obviously wrong. Just a few minor cleanups > needed. Fantastic! > > Which tree is this intended to go through? I'm more than happy to take > it through the EFI tree, particularly since it touches > include/linux/efi.h and drivers/firmware/efi/efi.c which is the core EFI > interface for all platforms. Your tree is perfect. I presume you do some automatic regression testing when you have accumulated a tons of patch - so if any of them cause havoc we can catch them before the merge window and fix them. > > But if it's going through the Xen tree or something, I can supply my > Acked-by's (once the aforementioned minor cleanups are taken care of). Nah, lets do your tree. And either Boris, me or David will supply the Acked-by on the drivers/xen* and arch/x86/xen/* so all the right tags are in place. Thanks again! > > -- > Matt Fleming, Intel Open Source Technology Center