From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v5 1/7] efi: Use early_mem*() instead of early_io*() Date: Wed, 18 Jun 2014 15:56:19 +0100 Message-ID: <20140618145619.GP24049@console-pimps.org> References: <1402678823-24589-1-git-send-email-daniel.kiper@oracle.com> <1402678823-24589-2-git-send-email-daniel.kiper@oracle.com> <20140618121709.GF24049@console-pimps.org> <20140618125957.GA28489@olila.local.net-space.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140618125957.GA28489-fJNZiO034lp9pOct4yEdx/3oZC3j2Omk@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Kiper Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, andrew.cooper3-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, eshelton-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, jbeulich-IBi9RG/b67k@public.gmane.org, jeremy-TSDbQ3PG+2Y@public.gmane.org, konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, Mark Salter List-Id: linux-efi@vger.kernel.org On Wed, 18 Jun, at 02:59:57PM, Daniel Kiper wrote: > > I think that it improves readability a bit but if you wish I will not > do that in the future. That would be much appreciated. > > As Matthew pointed out we may also need to access EFI mapped flash > > devices. > > Right, but I think it does not change a lot in that case. Flash > is simply slower type of memory used as permanent storage. > Am I missing something? No you're not missing anything, I hit send too quickly while typing my reply so the above isn't a complete thought. I don't think this distinction between mapped flash and RAM matters in this case. > As I saw David provided better explanation. If you wish I could include > it in commit message. Yeah, I think that would be very helpful, thanks! -- Matt Fleming, Intel Open Source Technology Center