From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leif Lindholm Subject: Re: [GIT PULL] EFI urgent fix Date: Fri, 20 Jun 2014 14:39:19 +0100 Message-ID: <20140620133919.GK4179@bivouac.eciton.net> References: <20140620090008.GU24049@console-pimps.org> <20140620092848.GC23939@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140620092848.GC23939-5wv7dgnIgG8@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Catalin Marinas Cc: Matt Fleming , "H. Peter Anvin" , Ingo Molnar , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-efi@vger.kernel.org On Fri, Jun 20, 2014 at 10:28:48AM +0100, Catalin Marinas wrote: > On Fri, Jun 20, 2014 at 10:00:08AM +0100, Matt Fleming wrote: > > Please pull the following compiler warning fix. Sorry, I've been pretty > > slow in getting this pull request sent. Multiple people have reported > > hitting it and I've now received 4 patches for the same warning, > > BTW, one of them is not just a simple warning but a bug. Pointer to > "long" variable on the stack passed to a function that only takes a > pointer to "int". We are probably lucky that we don't hit the bug on > arm64. > > Anyway, thanks for pushing the fix. > > (and lesson learnt not to trust the ARM EFI_STUB developers, won't name > them, with properly testing their code ;)) The code was tested and showed no runtime problems - but I did manage to miss the warnings. I did post an alternative patch for one half of this a week before anyone else, but that one seems to have been ignored, even by gmane: http://www.spinics.net/lists/linux-efi/msg03924.html That form will still be required for the 32-bit arm support, since strncmp is not available in the zImage. / Leif