public inbox for linux-efi@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@console-pimps.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Matt Fleming <matt.fleming@intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] efilinux: set ext_ramdisk_* for huge initrd
Date: Wed, 25 Jun 2014 21:47:00 +0100	[thread overview]
Message-ID: <20140625204700.GF15494@console-pimps.org> (raw)
In-Reply-To: <1403073669-6602-2-git-send-email-yinghai@kernel.org>

On Tue, 17 Jun, at 11:41:09PM, Yinghai Lu wrote:
> We could load it high if it is more than 2G when kernel support
> LOAD_ABOVE_4G.
> 
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> 
> ---
>  loaders/bzimage/bzimage.c |    9 ++++++++-
>  loaders/bzimage/bzimage.h |    8 ++++++--
>  2 files changed, 14 insertions(+), 3 deletions(-)
> 
> Index: efilinux/loaders/bzimage/bzimage.c
> ===================================================================
> --- efilinux.orig/loaders/bzimage/bzimage.c
> +++ efilinux/loaders/bzimage/bzimage.c
> @@ -130,7 +130,9 @@ static void parse_initrd(EFI_LOADED_IMAG
>  	if (err != EFI_SUCCESS)
>  		goto close_handles;
>  
> -	if ((UINTN)addr > boot_params->hdr.ramdisk_max) {
> +	if ((boot_params->hdr.version < 0x20c ||
> +	     !(boot_params->hdr.xloadflags & (1<<1))) &&
> +	    (UINTN)addr > boot_params->hdr.ramdisk_max) {

Could you please add a #define for the xloadflags bit?

-- 
Matt Fleming, Intel Open Source Technology Center

  reply	other threads:[~2014-06-25 20:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18  6:41 [PATCH 1/2] efilinux: Allocate boot_params before parsing initrd Yinghai Lu
2014-06-18  6:41 ` [PATCH 2/2] efilinux: set ext_ramdisk_* for huge initrd Yinghai Lu
2014-06-25 20:47   ` Matt Fleming [this message]
     [not found] ` <1403073669-6602-1-git-send-email-yinghai-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-06-25 20:45   ` [PATCH 1/2] efilinux: Allocate boot_params before parsing initrd Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140625204700.GF15494@console-pimps.org \
    --to=matt@console-pimps.org \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox