From: Matt Fleming <matt@console-pimps.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH v2] firmware: Do not use WARN_ON(!spin_is_locked())
Date: Thu, 14 Aug 2014 09:54:09 +0100 [thread overview]
Message-ID: <20140814085409.GX15082@console-pimps.org> (raw)
In-Reply-To: <1407954094-26126-1-git-send-email-linux@roeck-us.net>
On Wed, 13 Aug, at 11:21:34AM, Guenter Roeck wrote:
> spin_is_locked() always returns false for uniprocessor configurations
> in several architectures, so do not use WARN_ON with it.
> Use lockdep_assert_held() instead to also reduce overhead in
> non-debug kernels.
>
> Cc: Matt Fleming <matt.fleming@intel.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: Use lockdep_assert_held instead of WARN_ON_SMP.
>
> drivers/firmware/efi/vars.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Thanks Guenter, applied!
--
Matt Fleming, Intel Open Source Technology Center
prev parent reply other threads:[~2014-08-14 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 18:21 [PATCH v2] firmware: Do not use WARN_ON(!spin_is_locked()) Guenter Roeck
2014-08-14 8:54 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814085409.GX15082@console-pimps.org \
--to=matt@console-pimps.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matt.fleming@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox