* [PATCH v2] efi/arm64: store Runtime Services revision
@ 2014-08-15 13:22 Semen Protsenko
[not found] ` <1408108964-28650-1-git-send-email-semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Semen Protsenko @ 2014-08-15 13:22 UTC (permalink / raw)
To: matt.fleming-ral2JQCrhuEAvxtiuMwx3w, x86-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
leif.lindholm-QSEj5FYQhm4dnm+yROfE0A,
roy.franz-QSEj5FYQhm4dnm+yROfE0A,
ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A,
catalin.marinas-5wv7dgnIgG8, msalter-H+wXaHxf7aLQT0dZR+AlfA
"efi" global data structure contains "runtime_version" field which must
be assigned in order to use it later in Runtime Services virtual calls
(virt_efi_* functions).
Before this patch "runtime_version" was unassigned (0), so each
Runtime Service virtual call that checks revision would fail.
Signed-off-by: Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
arch/arm64/kernel/efi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c
index e72f310..5dbb7bd 100644
--- a/arch/arm64/kernel/efi.c
+++ b/arch/arm64/kernel/efi.c
@@ -463,6 +463,8 @@ static int __init arm64_enter_virtual_mode(void)
efi_native_runtime_setup();
set_bit(EFI_RUNTIME_SERVICES, &efi.flags);
+ efi.runtime_version = efi.systab->hdr.revision;
+
return 0;
err_unmap:
--
2.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] efi/arm64: store Runtime Services revision
[not found] ` <1408108964-28650-1-git-send-email-semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2014-08-15 13:38 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9ABf9VzMiT-nA1tt8tbjimCZGatiT1ucwcFTnt7qdmfQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2014-08-15 13:38 UTC (permalink / raw)
To: Semen Protsenko
Cc: Matt Fleming, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Leif Lindholm, Roy Franz, Catalin Marinas, Mark Salter
On 15 August 2014 15:22, Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> "efi" global data structure contains "runtime_version" field which must
> be assigned in order to use it later in Runtime Services virtual calls
> (virt_efi_* functions).
>
> Before this patch "runtime_version" was unassigned (0), so each
> Runtime Service virtual call that checks revision would fail.
>
> Signed-off-by: Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Acked-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@Matt, could you take this?
--
Ard.
> ---
> arch/arm64/kernel/efi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c
> index e72f310..5dbb7bd 100644
> --- a/arch/arm64/kernel/efi.c
> +++ b/arch/arm64/kernel/efi.c
> @@ -463,6 +463,8 @@ static int __init arm64_enter_virtual_mode(void)
> efi_native_runtime_setup();
> set_bit(EFI_RUNTIME_SERVICES, &efi.flags);
>
> + efi.runtime_version = efi.systab->hdr.revision;
> +
> return 0;
>
> err_unmap:
> --
> 2.0.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] efi/arm64: store Runtime Services revision
[not found] ` <CAKv+Gu9ABf9VzMiT-nA1tt8tbjimCZGatiT1ucwcFTnt7qdmfQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-08-15 13:43 ` Matt Fleming
[not found] ` <20140815134324.GY15082-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Matt Fleming @ 2014-08-15 13:43 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Semen Protsenko, Matt Fleming,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Leif Lindholm, Roy Franz, Catalin Marinas, Mark Salter
On Fri, 15 Aug, at 03:38:48PM, Ard Biesheuvel wrote:
> On 15 August 2014 15:22, Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> > "efi" global data structure contains "runtime_version" field which must
> > be assigned in order to use it later in Runtime Services virtual calls
> > (virt_efi_* functions).
> >
> > Before this patch "runtime_version" was unassigned (0), so each
> > Runtime Service virtual call that checks revision would fail.
> >
> > Signed-off-by: Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> @Matt, could you take this?
Certainly. Looks like this should go into the 'urgent' queue and be
tagged for stable?
--
Matt Fleming, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] efi/arm64: store Runtime Services revision
[not found] ` <20140815134324.GY15082-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
@ 2014-08-15 13:55 ` Ard Biesheuvel
0 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2014-08-15 13:55 UTC (permalink / raw)
To: Matt Fleming
Cc: Semen Protsenko, Matt Fleming,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Leif Lindholm, Roy Franz, Catalin Marinas, Mark Salter
On 15 August 2014 15:43, Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> wrote:
> On Fri, 15 Aug, at 03:38:48PM, Ard Biesheuvel wrote:
>> On 15 August 2014 15:22, Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>> > "efi" global data structure contains "runtime_version" field which must
>> > be assigned in order to use it later in Runtime Services virtual calls
>> > (virt_efi_* functions).
>> >
>> > Before this patch "runtime_version" was unassigned (0), so each
>> > Runtime Service virtual call that checks revision would fail.
>> >
>> > Signed-off-by: Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>
>> Acked-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>
>> @Matt, could you take this?
>
> Certainly. Looks like this should go into the 'urgent' queue and be
> tagged for stable?
>
Yes, please (for 3.16)
--
Ard.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-15 13:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-15 13:22 [PATCH v2] efi/arm64: store Runtime Services revision Semen Protsenko
[not found] ` <1408108964-28650-1-git-send-email-semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-08-15 13:38 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9ABf9VzMiT-nA1tt8tbjimCZGatiT1ucwcFTnt7qdmfQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-15 13:43 ` Matt Fleming
[not found] ` <20140815134324.GY15082-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-08-15 13:55 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).