[PATCH v2] efi/arm64: store Runtime Services revision

[PATCH v2] efi/arm64: store Runtime Services revision

[Semen Protsenko]

"efi" global data structure contains "runtime_version" field which must
be assigned in order to use it later in Runtime Services virtual calls
(virt_efi_* functions).

Before this patch "runtime_version" was unassigned (0), so each
Runtime Service virtual call that checks revision would fail.

Signed-off-by: Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 arch/arm64/kernel/efi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c
index e72f310..5dbb7bd 100644
--- a/arch/arm64/kernel/efi.c
+++ b/arch/arm64/kernel/efi.c
@@ -463,6 +463,8 @@ static int __init arm64_enter_virtual_mode(void)
 	efi_native_runtime_setup();
 	set_bit(EFI_RUNTIME_SERVICES, &efi.flags);
 
+	efi.runtime_version = efi.systab->hdr.revision;
+
 	return 0;
 
 err_unmap:
-- 
2.0.1

Re: [PATCH v2] efi/arm64: store Runtime Services revision

[Ard Biesheuvel]

On 15 August 2014 15:22, Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> "efi" global data structure contains "runtime_version" field which must
> be assigned in order to use it later in Runtime Services virtual calls
> (virt_efi_* functions).
>
> Before this patch "runtime_version" was unassigned (0), so each
> Runtime Service virtual call that checks revision would fail.
>
> Signed-off-by: Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Acked-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

@Matt, could you take this?

-- 
Ard.


> ---
>  arch/arm64/kernel/efi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c
> index e72f310..5dbb7bd 100644
> --- a/arch/arm64/kernel/efi.c
> +++ b/arch/arm64/kernel/efi.c
> @@ -463,6 +463,8 @@ static int __init arm64_enter_virtual_mode(void)
>         efi_native_runtime_setup();
>         set_bit(EFI_RUNTIME_SERVICES, &efi.flags);
>
> +       efi.runtime_version = efi.systab->hdr.revision;
> +
>         return 0;
>
>  err_unmap:
> --
> 2.0.1
>

Re: [PATCH v2] efi/arm64: store Runtime Services revision

[Matt Fleming]

On Fri, 15 Aug, at 03:38:48PM, Ard Biesheuvel wrote:
> On 15 August 2014 15:22, Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> > "efi" global data structure contains "runtime_version" field which must
> > be assigned in order to use it later in Runtime Services virtual calls
> > (virt_efi_* functions).
> >
> > Before this patch "runtime_version" was unassigned (0), so each
> > Runtime Service virtual call that checks revision would fail.
> >
> > Signed-off-by: Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> 
> @Matt, could you take this?

Certainly. Looks like this should go into the 'urgent' queue and be
tagged for stable?

-- 
Matt Fleming, Intel Open Source Technology Center

Re: [PATCH v2] efi/arm64: store Runtime Services revision

[Ard Biesheuvel]

On 15 August 2014 15:43, Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> wrote:
> On Fri, 15 Aug, at 03:38:48PM, Ard Biesheuvel wrote:
>> On 15 August 2014 15:22, Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>> > "efi" global data structure contains "runtime_version" field which must
>> > be assigned in order to use it later in Runtime Services virtual calls
>> > (virt_efi_* functions).
>> >
>> > Before this patch "runtime_version" was unassigned (0), so each
>> > Runtime Service virtual call that checks revision would fail.
>> >
>> > Signed-off-by: Semen Protsenko <semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>
>> Acked-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>
>> @Matt, could you take this?
>
> Certainly. Looks like this should go into the 'urgent' queue and be
> tagged for stable?
>

Yes, please (for 3.16)

-- 
Ard.