From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH] efi/arm64: store Runtime Services revision Date: Tue, 26 Aug 2014 10:05:33 +0100 Message-ID: <20140826090533.GA3193@arm.com> References: <1408028122-1784-1-git-send-email-semen.protsenko@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1408028122-1784-1-git-send-email-semen.protsenko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Semen Protsenko Cc: "matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , Catalin Marinas , "leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-efi@vger.kernel.org On Thu, Aug 14, 2014 at 03:55:22PM +0100, Semen Protsenko wrote: > "efi" global data structure contains "runtime_version" field which must > be assigned in order to use it later in Runtime Services virtual calls > (virt_efi_* functions). > > Before this patch "runtime_version" was unassigned (0), so each > Runtime Service virtual call that checks revision would fail. > > Runtime Services revision being passed in UEFI system table from UEFI > to kernel (see efi_entry() function). In UEFI it's being stored at > MdePkg/Include/Uefi/UefiSpec.h as EFI_RUNTIME_SERVICES_REVISION. > > Signed-off-by: Semen Protsenko > --- > arch/arm64/kernel/efi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c > index e72f310..5dbb7bd 100644 > --- a/arch/arm64/kernel/efi.c > +++ b/arch/arm64/kernel/efi.c > @@ -463,6 +463,8 @@ static int __init arm64_enter_virtual_mode(void) > efi_native_runtime_setup(); > set_bit(EFI_RUNTIME_SERVICES, &efi.flags); > > + efi.runtime_version = efi.systab->hdr.revision; > + > return 0; I doubt it makes any difference, but can we assign this before we call efi_native_runtime_setup please? Will