From: Matt Fleming <matt@console-pimps.org>
To: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Cc: Ulf Winkelvos <ulf@winkelvos.de>,
Matt Fleming <matt.fleming@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-efi@vger.kernel.org,
Seth Forshee <seth.forshee@canonical.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [REGRESSION] "efi: efistub: Convert into static library" and preparation patches
Date: Tue, 2 Sep 2014 20:29:41 +0100 [thread overview]
Message-ID: <20140902192941.GB3001@console-pimps.org> (raw)
In-Reply-To: <5405E186.2080406@canonical.com>
On Tue, 02 Sep, at 05:25:58PM, Maarten Lankhorst wrote:
> Hey,
>
> My macbook pro 8.2 fails to do a efi stub boot with these patches.
>
> Commit f23cf8bd5c1f49 "efi/x86: efistub: Move shared dependencies to <asm/efi.h>"
> causes the first break, but this can be averted by changing
>
> struct efi_config *efi_early;
>
> to
>
> struct efi_config *efi_early __attribute__((visibility("hidden")));
Weird. That sounds like a bug in the Apple EFI PE loader. Does any other
visibility result in a working kernel?
> I also need to revert commit f4f75ad5741fe "efi: efistub: Convert into static library"
> to get boot working.
I'll take a look at the symbol changes between these commits and try and
guess what's going on.
> I'm not an early boot expert, so I have no idea what's going on here.
> Only console output I see when the boot fails is "setup_efi_pci() failed!" after
> the commit that adds this message.
Yeah, that should be unrelated.
Thanks for the report.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-09-02 19:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 15:25 [REGRESSION] "efi: efistub: Convert into static library" and preparation patches Maarten Lankhorst
2014-09-02 19:29 ` Matt Fleming [this message]
2014-09-03 6:06 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_eSe+FeNkGm+w3sSsRn2_hr70xLVBieZgyhawAv6PQvw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-03 8:27 ` Maarten Lankhorst
[not found] ` <5406D0DB.90401-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2014-09-03 12:18 ` Ard Biesheuvel
2014-09-03 15:30 ` Maarten Lankhorst
[not found] ` <54073409.6030004-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2014-09-03 15:37 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9q1qTh6DZXsCG2tGVBn-uwuQKQa_6FEMmchDVFi5vJtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-03 17:59 ` Matt Fleming
[not found] ` <20140903175948.GH3001-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-03 19:57 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9tejixb3Kb3YM_7sLcpKNuRHN+Dn+twFyCAXx99wYRCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-03 21:28 ` H. Peter Anvin
2014-09-04 10:48 ` Maarten Lankhorst
[not found] ` <54084376.8090002-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2014-09-04 11:19 ` Ard Biesheuvel
[not found] ` <BA3DE6F4-93D9-4CDE-90D7-280360929ABD-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-04 11:24 ` Maarten Lankhorst
2014-09-04 12:54 ` Michael Brown
[not found] ` <540860F1.6060801-OViyBiuKJBuK421+ScFKDQ@public.gmane.org>
2014-09-04 19:12 ` Ard Biesheuvel
2014-09-04 21:25 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_sLmkBHF-9GyPUgfAbLYirQTD4vk63o6HzdZhm6s_e0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-04 21:37 ` Matt Fleming
[not found] ` <20140904213753.GM3001-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-05 20:27 ` Matt Fleming
[not found] ` <20140905202744.GO3001-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-08 12:55 ` Ard Biesheuvel
[not found] ` <CAKv+Gu8GOHMa=zVWBG7OdSG2i2Ag_XyEBE5NzU6ffLNP8zA3Ug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-08 13:01 ` Maarten Lankhorst
2014-09-08 13:16 ` Matt Fleming
2014-09-22 18:44 ` Josh Boyer
2014-09-22 21:07 ` Matt Fleming
2014-09-22 21:24 ` Josh Boyer
2014-09-03 21:47 ` H. Peter Anvin
[not found] ` <54078C74.2060804-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2014-09-04 6:47 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902192941.GB3001@console-pimps.org \
--to=matt@console-pimps.org \
--cc=ard.biesheuvel@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=matt.fleming@intel.com \
--cc=mjg59@srcf.ucam.org \
--cc=seth.forshee@canonical.com \
--cc=ulf@winkelvos.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox