From: Matt Fleming <matt@console-pimps.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "Matt Fleming" <matt.fleming@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Mantas Mikulėnas" <grawity@gmail.com>,
"Anders Darander" <anders@chargestorm.se>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -v3] x86: only load initrd above 4g on second try
Date: Wed, 3 Sep 2014 14:43:14 +0100 [thread overview]
Message-ID: <20140903134314.GG3001@console-pimps.org> (raw)
In-Reply-To: <1409696740-14981-1-git-send-email-yinghai@kernel.org>
On Tue, 02 Sep, at 03:25:40PM, Yinghai Lu wrote:
> Mantas found that after commit 4bf7111f5016 ("x86/efi: Support initrd
> loaded above 4G"), the kernel freezes at the earliest possible moment
> when trying to boot via UEFI on Asus laptop.
>
> Revert to old way to load initrd under 4G on first try,
> second try will use above 4G buffer when initrd is too big
> and does not fit under 4G.
>
> -v2: add print out for second try, and print out files buf address.
> -v3: can not snprintf
>
> Reported-by: Mantas Mikulėnas <grawity@gmail.com>
> Tested-by: Anders Darander <anders@chargestorm.se>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
I'm still seeing build errors/warnings with this version,
drivers/firmware/efi/libstub/lib.a(efi-stub-helper.o): In function `handle_cmdline_files':
efi-stub-helper.c:(.text+0xb7a): undefined reference to `sprintf'
Please drop the second hunk.
--
Matt Fleming, Intel Open Source Technology Center
prev parent reply other threads:[~2014-09-03 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 22:25 [PATCH -v3] x86: only load initrd above 4g on second try Yinghai Lu
2014-09-03 13:43 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903134314.GG3001@console-pimps.org \
--to=matt@console-pimps.org \
--cc=anders@chargestorm.se \
--cc=grawity@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox