From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [REGRESSION] "efi: efistub: Convert into static library" and preparation patches Date: Thu, 4 Sep 2014 22:37:53 +0100 Message-ID: <20140904213753.GM3001@console-pimps.org> References: <5406D0DB.90401@canonical.com> <54073409.6030004@canonical.com> <20140903175948.GH3001@console-pimps.org> <54084376.8090002@canonical.com> <540860F1.6060801@fensystems.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: Michael Brown , Maarten Lankhorst , Ulf Winkelvos , Matt Fleming , LKML , "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "H. Peter Anvin" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Seth Forshee , Matthew Garrett List-Id: linux-efi@vger.kernel.org On Thu, 04 Sep, at 11:25:48PM, Ard Biesheuvel wrote: > > As it turns out, this breaks 32-bit, and the linker script is shared. > > So I suggest that we go with Matt's suggestion, i.e., move/clone the > GOT fixup code so that it runs exactly once in each code path, but > early enough so that the embedded EFI application gets the treatment > too. > And don't forget head_32.S ... Thanks Ard, I'll take a look in the morning. -- Matt Fleming, Intel Open Source Technology Center