From: Matt Fleming <matt@console-pimps.org>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Matt Fleming <matt.fleming@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
hock.leong.kweh@intel.com,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] efi: Capsule update support
Date: Mon, 13 Oct 2014 10:53:10 +0100 [thread overview]
Message-ID: <20141013095310.GZ14343@console-pimps.org> (raw)
In-Reply-To: <CAGBcZGfHX57jwCfw7CnvLgOJ58kd0KVJULOvhAsfi=3YBp5WsQ@mail.gmail.com>
On Fri, 10 Oct, at 06:55:49PM, Sam Protsenko wrote:
> Hi Matt,
>
> 1. Why x86 code isn't separated to another patch?
When I originally wrote this patch in 2013 arm64 support didn't exist,
and ia64 isn't going to be using capsule support. I can separate that
out into a separate patch though, no problem.
> 2. drivers/firmware/efi/reboot.c: efi_reboot():
> One shouldn't use "printk()" with no KERN_* stuff passed into it.
> I'd recommend to use "pr_info()" macro or something like that.
Oops, I missed that, good catch.
Next time, could you please quote the part of the patch you're
commenting on inline? That would have saved me searching through the
original email.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-10-13 9:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 15:55 [PATCH 2/2] efi: Capsule update support Sam Protsenko
2014-10-13 9:53 ` Matt Fleming [this message]
[not found] ` <20141013095310.GZ14343-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-10-13 15:43 ` Sam Protsenko
[not found] ` <CAGBcZGe=HszCxQyx8bBDUEQcF4g+gcMyLfGiM4dVz4=TfxvLpg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-14 15:30 ` Sam Protsenko
[not found] ` <CAGBcZGfSdYa2yXW68RbywzCiC7mTxjAdGjUnwnhjWAwXZ0uqiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-16 16:15 ` Matt Fleming
[not found] ` <20141016161507.GJ14343-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-11-04 13:56 ` Sam Protsenko
2014-11-07 15:12 ` Matt Fleming
-- strict thread matches above, loose matches on Subject: below --
2014-10-07 14:42 [PATCH 1/2] efi: Move efi_status_to_err() to efi.h Matt Fleming
[not found] ` <1412692951-25478-1-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-10-07 14:42 ` [PATCH 2/2] efi: Capsule update support Matt Fleming
[not found] ` <1412692951-25478-2-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-10-10 18:28 ` Borislav Petkov
[not found] ` <20141010182846.GA10588-fF5Pk5pvG8Y@public.gmane.org>
2014-10-14 21:46 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141013095310.GZ14343@console-pimps.org \
--to=matt@console-pimps.org \
--cc=hock.leong.kweh@intel.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox