From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 05/10] arm64/efi: drop redundant set_bit(EFI_CONFIG_TABLES) Date: Mon, 27 Oct 2014 12:22:07 +0000 Message-ID: <20141027122206.GS8768@arm.com> References: <1413987713-30528-1-git-send-email-ard.biesheuvel@linaro.org> <1413987713-30528-6-git-send-email-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1413987713-30528-6-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: "leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , Mark Rutland , Catalin Marinas , "matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "yi.li-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" List-Id: linux-efi@vger.kernel.org On Wed, Oct 22, 2014 at 03:21:48PM +0100, Ard Biesheuvel wrote: > The EFI_CONFIG_TABLES bit already gets set by efi_config_init(), > so there is no reason to set it again after this function returns > successfully. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/kernel/efi.c | 2 -- > 1 file changed, 2 deletions(-) Since you mentioned it, Acked-by: Will Deacon Will > diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c > index 71ea4fc0aa8a..51522ab0c6da 100644 > --- a/arch/arm64/kernel/efi.c > +++ b/arch/arm64/kernel/efi.c > @@ -112,8 +112,6 @@ static int __init uefi_init(void) > efi.systab->hdr.revision & 0xffff, vendor); > > retval = efi_config_init(NULL); > - if (retval == 0) > - set_bit(EFI_CONFIG_TABLES, &efi.flags); > > out: > early_memunmap(efi.systab, sizeof(efi_system_table_t)); > -- > 1.8.3.2 > >